-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ecommerce version bump 1.3.33 #1117
Conversation
6 failed tests on run #8743 ↗︎
Details:
vendor/newfold-labs/wp-module-coming-soon/tests/cypress/integration/coming-soon.cy.js • 1 failed test
vendor/newfold-labs/wp-module-deactivation/tests/cypress/integration/deactivation-survey.cy.js • 2 failed testsvendor/newfold-labs/wp-module-marketplace/tests/cypress/integration/product-page.cy.js • 3 failed testsReview all test suite changes for PR #1117 ↗︎ |
Looks like these latest e-commerce module releases (1.3.32 and 1.3.33) do not have passing cypress tests. I see there are more tests being skipped and still failing tests not being skipped. Ideally we do not skip tests but can update them to pass. This is the only way to ensure code integrity and functional products for users. Passing tests is a requirement for tagging a module release. |
@sangeetha-nayak Can you please take a look at failed cypress tests? |
Hi @circlecube , the latest ecommerce version 1.3.33 has been released to fix all the ecommerce related tests, In the current PR, the tests that are failing are from other modules, coming soon and deactivation module. We skipped a test that is wondercart related as that is breaking because of console errors coming from features module. So, we skipped it for now until it is fixed. |
Branches should follow the naming convention so that workflows will trigger tests to run. See https://newfold-labs.github.io/how-we-work/9-version-control.html#branch-naming and https://github.com/bluehost/bluehost-wordpress-plugin/blob/main/.github/workflows/cypress.yml#L6-L15 |
Since we have a conflict and branch name didn't trigger tests, I've set a new PR up at #1128. Closing this one. |
Proposed changes
PRESS0-1325
: Post Migration scripts by @krsomayagi in Post Migration scripts newfold-labs/wp-module-ecommerce#307PRESS0-1159
: Update Store Home Page by @aratidgr8 @manikantakailasa in Press0 1159 newfold-labs/wp-module-ecommerce#308PRESS0-1448
: Remove Unused Thumbnail Service Code by @arunshenoy99 in Remove Unused Thumbnail Service Code newfold-labs/wp-module-ecommerce#315Type of Change
Checklist
Further comments