Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecommerce version bump 1.3.33 #1117

Closed
wants to merge 4 commits into from
Closed

Conversation

aratidgr8
Copy link
Contributor

@aratidgr8 aratidgr8 commented Jun 12, 2024

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@aratidgr8 aratidgr8 requested review from circlecube and wpalani June 12, 2024 12:22
@aratidgr8 aratidgr8 changed the base branch from main to develop June 12, 2024 12:27
Copy link

cypress bot commented Jun 12, 2024

6 failed tests on run #8743 ↗︎

6 384 59 0 Flakiness 0

Details:

Merge 4c57fb0 into 6e8d8bb...
Project: Bluehost Brand Plugin Commit: 7a0e6e1352 ℹ️
Status: Failed Duration: 25:10 💡
Started: Jun 19, 2024 5:40 AM Ended: Jun 19, 2024 6:05 AM
Failed  vendor/newfold-labs/wp-module-coming-soon/tests/cypress/integration/coming-soon.cy.js • 1 failed test

View Output Video

Test Artifacts
Coming Soon > Launching launches site Test Replay Screenshots Video
Failed  vendor/newfold-labs/wp-module-deactivation/tests/cypress/integration/deactivation-survey.cy.js • 2 failed tests

View Output Video

Test Artifacts
Plugin Deactivation Survey > Continue button exists and advances to survey, skip button functions Test Replay Screenshots Video
Plugin Deactivation Survey > Survey successfully deactivates plugin Test Replay Screenshots Video
Failed  vendor/newfold-labs/wp-module-marketplace/tests/cypress/integration/product-page.cy.js • 3 failed tests

View Output Video

Test Artifacts
Product Page > Show loading state while fetching Test Replay Screenshots Video
Product Page > Product page content is visible Test Replay Screenshots Video
Product Page > Show error state if fetching fails Test Replay Screenshots Video

Review all test suite changes for PR #1117 ↗︎

@circlecube
Copy link
Member

Looks like these latest e-commerce module releases (1.3.32 and 1.3.33) do not have passing cypress tests. I see there are more tests being skipped and still failing tests not being skipped. Ideally we do not skip tests but can update them to pass. This is the only way to ensure code integrity and functional products for users.

Passing tests is a requirement for tagging a module release.

@aratidgr8
Copy link
Contributor Author

@sangeetha-nayak Can you please take a look at failed cypress tests?

@aratidgr8 aratidgr8 changed the title Ecommerce version bump 1.3.32 Ecommerce version bump 1.3.33 Jun 19, 2024
@ramyakrishnai
Copy link
Contributor

Hi @circlecube , the latest ecommerce version 1.3.33 has been released to fix all the ecommerce related tests, In the current PR, the tests that are failing are from other modules, coming soon and deactivation module. We skipped a test that is wondercart related as that is breaking because of console errors coming from features module. So, we skipped it for now until it is fixed.

@circlecube circlecube added this to the 3.12.0 milestone Jun 19, 2024
@circlecube
Copy link
Member

Branches should follow the naming convention so that workflows will trigger tests to run. See https://newfold-labs.github.io/how-we-work/9-version-control.html#branch-naming and https://github.com/bluehost/bluehost-wordpress-plugin/blob/main/.github/workflows/cypress.yml#L6-L15

@circlecube circlecube mentioned this pull request Jun 19, 2024
8 tasks
@circlecube
Copy link
Member

Since we have a conflict and branch name didn't trigger tests, I've set a new PR up at #1128. Closing this one.

@circlecube circlecube closed this Jun 19, 2024
@circlecube circlecube deleted the ecommerce-version-bump-1.3.32 branch June 19, 2024 14:01
@circlecube circlecube removed this from the 3.12.0 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants