Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Press0 1323 | bookings ctb added in pages and posts #1119

Closed
wants to merge 3 commits into from

Conversation

ramyakrishnai
Copy link
Contributor

@ramyakrishnai ramyakrishnai commented Jun 14, 2024

Proposed changes

When they view Pages and Posts (launchpad) in wp-admin
Then we will have CTB for bookings instead of removing the card altogether if they dont have bookings installed.

story: https://jira.newfold.com/browse/PRESS0-1323
Raised this PR to run all the tests bookings ctb added in pages and posts #1118

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@ramyakrishnai ramyakrishnai changed the title Press0 1323 Press0 1323 | bookings ctb added in pages and posts Jun 14, 2024
Copy link

cypress bot commented Jun 14, 2024

6 failed and 1 flaky tests on run #8683 ↗︎

6 385 49 2 Flakiness 1

Details:

Merge cc2cf79 into 94b6fe5...
Project: Bluehost Brand Plugin Commit: f36f701b98 ℹ️
Status: Failed Duration: 33:06 💡
Started: Jun 14, 2024 10:34 AM Ended: Jun 14, 2024 11:07 AM
Failed  Site-Capabilities/siteCapabilities.cy.js • 5 failed tests

View Output Video

Test Artifacts
Verify Wondercart accessibility as per site capabilities > Verify if Sales and Discounts sub tab is displayed Test Replay Screenshots Video
Verify Wondercart accessibility as per site capabilities > Verify Buy Now is shown when canAccessGlobalCTB is true and commerce addon is false Test Replay Screenshots Video
Verify Wondercart accessibility as per site capabilities > Verify clicking on Buy Now leads to cpanel login page Test Replay Screenshots Video
Verify Wondercart accessibility as per site capabilities > Verify Install Now is shown when customer has ecommerce addon Test Replay Screenshots Video
Verify Wondercart accessibility as per site capabilities > Verify clicking Install Now successfully installs Wonder Cart plugin Test Replay Screenshots Video
Failed  Store/storePage.cy.js • 1 failed test

View Output Video

Test Artifacts
Store Page- WooCommerce is deactivated/uninstalled > Verify that Payments tab is not displayed Test Replay Screenshots Video
Flakiness  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/commerceHomePage.cy.js • 1 flaky test

View Output Video

Test Artifacts
Commerce Home Page- Next Steps > Verify Next steps when experience level is novice Test Replay Screenshots Video

Review all test suite changes for PR #1119 ↗︎

@wpalani
Copy link
Member

wpalani commented Jun 18, 2024

It looks like the requirements for the story have changed after this PR was opened. We also have a design to address this functionality. We're closing this PR for now. You can open a new one addressing the updated story and design.

I threw a comment for you on that Jira story.

p.s: please include cypress tests in your future PR.

Thanks!

@wpalani wpalani closed this Jun 18, 2024
@wpalani wpalani deleted the PRESS0-1323 branch July 18, 2024 19:44
@wpalani wpalani restored the PRESS0-1323 branch July 18, 2024 19:45
@wpalani wpalani deleted the PRESS0-1323 branch July 18, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants