Marketplace single product pages #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though this issue is not related to this PR. fixing it here anyway.
2 failed and 1 flaky tests on run #8740 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Verify Wondercart accessibility as per site capabilities > Verify clicking Install Now successfully installs Wonder Cart plugin |
Test Replay
Screenshots
Video
|
|
Store/storePage.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Store Page- WooCommerce is deactivated/uninstalled > Verify that Payments tab is not displayed |
Test Replay
Screenshots
Video
|
|
vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/commerceHomePage.cy.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Commerce Home Page- Next Steps > Verify Next steps when experience level is novice |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #1127 ↗︎
circlecube
approved these changes
Jun 19, 2024
* develop: NPM(deps): Bump @wordpress/element from 5.35.0 to 6.1.0 NPM(deps): Bump @wordpress/html-entities from 3.58.0 to 4.1.0 Composer Dev(deps-dev): Bump wp-phpunit/wp-phpunit from 6.5.3 to 6.5.4 NPM(deps): Bump @wordpress/dom-ready from 3.58.0 to 4.1.0 NPM Dev(deps-dev): Bump @testing-library/cypress from 10.0.1 to 10.0.2 # Conflicts: # composer.lock
|
Noting that marketplace tests pass here, but e-commerce tests fail (but are fixed on another PR) performance and staging tests are failing. Assuming it's a fluke as because the app doesn't load, and all these tests are at the end and failing. Looks like something in onboarding caused issues, probably another plugin that was installed. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds the necessary changes to the brand plugin that are needed by the Marketplace module to show the single product pages: newfold-labs/wp-module-marketplace#70
2.3.0which includes the new components and tests.react-router-dom'suseMatchanduseNavigatemethods to the module.Type of Change
Checklist
Further comments
Internal ticket: https://jira.newfold.com/browse/PRESS0-441