use classNames

[circlecube]

Proposed changes

This makes the use of the classnames library consistent throughout the plugin. We are importing it as classNames in the webpack config and also importing it as classnames in a few files and passing to some module components. This cleans all that up so we no longer import a duplicate package, and consistently use classNames.

This also requires an update to a few modules: marketplace, notifications, and staging. We were passing the classnames version to the components in performance module too, but it wasn't being used, so we can just remove it on the plugin side.

Type of Change

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)

Checklist

• I have read the CONTRIBUTING doc
• Linting and tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Further comments

[circlecube]

Tests will likely fail here until we bump the module versions. PRs for those are here:

• update classnames to classNames newfold-labs/wp-module-marketplace#76 - updates the expected method name
• remove methods.classnames as its not used newfold-labs/wp-module-notifications#26 - removes the dependency since its isn't used
• update classnames to classNames newfold-labs/wp-module-staging#27 - updates the expected method name

[cypress]

1 flaky test on run #9021 ↗︎

0

387

59

0

1

Details:

update modules with classnames fixes
Project: Bluehost Brand Plugin	Commit: a20c6f53e2
Status: Passed	Duration: 26:45 💡
Started: Jul 3, 2024 5:41 PM	Ended: Jul 3, 2024 6:08 PM

  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/homePageWithWoo.cy.js • 1 flaky test

View Output Video

Test		Artifacts
e-commerce Home Page - When WooCommerce is installed > Verify next steps "Add your store info"		Test Replay Screenshots Video

Review all test suite changes for PR #1167 ↗︎