Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Active Products in Brand Plugin #1170

Merged
merged 15 commits into from
Aug 21, 2024

Conversation

girish-lokapure
Copy link
Contributor

@girish-lokapure girish-lokapure commented Jul 5, 2024

Proposed changes

The scope of this PR includes:

  • Creation of a "My Products" section on the home page in brand plugin that lists out products.
  • A/B test "abTestShowMyProducts" set to zero percent so we can turn it on for a few people and get feedback

image

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@girish-lokapure girish-lokapure marked this pull request as ready for review July 5, 2024 06:02
@wpscholar wpscholar added this to the July 17 Release milestone Jul 5, 2024
@wpalani
Copy link
Member

wpalani commented Jul 11, 2024

Module for this feature has not yet been released. Pushing this to the July 24th milestone.

@chrisdavidmiles
Copy link
Contributor

Can you push it out another week? There's more things that need to be addressed before this is ready.

  • Let's not make it a top level nav, just put it on the homepage underneath everything else.
  • Make it an A/B test set to zero percent so we can turn it on for a few people and get feedback.

@wpalani
Copy link
Member

wpalani commented Jul 17, 2024

Can you push it out another week? There's more things that need to be addressed before this is ready.

  • Let's not make it a top level nav, just put it on the homepage underneath everything else.
  • Make it an A/B test set to zero percent so we can turn it on for a few people and get feedback.

Pushed to July 31 milestone.

@girish-lokapure girish-lokapure marked this pull request as draft July 22, 2024 12:34
@girish-lokapure girish-lokapure marked this pull request as ready for review July 24, 2024 15:09
@girish-lokapure
Copy link
Contributor Author

girish-lokapure commented Jul 24, 2024

Can you push it out another week? There's more things that need to be addressed before this is ready.

  • Let's not make it a top level nav, just put it on the homepage underneath everything else.
  • Make it an A/B test set to zero percent so we can turn it on for a few people and get feedback.

I have implemented the changes, please check the screenshot attached. @wpalani please review the changes

@diwanshuster diwanshuster requested a review from wpalani July 25, 2024 07:29
@wpalani wpalani added this to the August 7 Release milestone Jul 31, 2024
@wpalani
Copy link
Member

wpalani commented Aug 1, 2024

I did some testing and this doesn't seem to be working. I added a comment detailing the issue here: https://jira.newfold.com/browse/PRESS0-719?focusedCommentId=14721912&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14721912

Pushing this to August 14 milestone.

@girish-lokapure
Copy link
Contributor Author

I did some testing and this doesn't seem to be working. I added a comment detailing the issue here: https://jira.newfold.com/browse/PRESS0-719?focusedCommentId=14721912&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14721912

Pushing this to August 14 milestone.

Seems like the env variables are missing and needs to be added to vapor
FULFILLMENT_GATEWAY_API =""
FULFILLMENT_GATEWAY_SYSTEM_ID = ""
FULFILLMENT_GATEWAY_SECRET = ""

Copy link

cypress bot commented Aug 6, 2024



Test summary

418 0 36 0Flakiness 0


Run details

Project Bluehost Brand Plugin
Status Passed
Commit 4cbf227
Started Aug 6, 2024 9:21 PM
Ended Aug 6, 2024 9:47 PM
Duration 25:59 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@wpalani
Copy link
Member

wpalani commented Aug 7, 2024

This PR is currently blocked by https://jira.newfold.com/browse/PRESS1-423

@chrisdavidmiles
Copy link
Contributor

Is this ready to go into the Aug 28 release?

@wpalani
Copy link
Member

wpalani commented Aug 21, 2024

Is this ready to go into the Aug 28 release?

That's the plan, doing some testing on it today.

@wpalani wpalani merged commit e834d96 into bluehost:develop Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants