-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Active Products in Brand Plugin #1170
Conversation
Module for this feature has not yet been released. Pushing this to the July 24th milestone. |
Can you push it out another week? There's more things that need to be addressed before this is ready.
|
Pushed to July 31 milestone. |
I have implemented the changes, please check the screenshot attached. @wpalani please review the changes |
I did some testing and this doesn't seem to be working. I added a comment detailing the issue here: https://jira.newfold.com/browse/PRESS0-719?focusedCommentId=14721912&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14721912 Pushing this to August 14 milestone. |
Seems like the env variables are missing and needs to be added to vapor |
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
This PR is currently blocked by https://jira.newfold.com/browse/PRESS1-423 |
Is this ready to go into the Aug 28 release? |
That's the plan, doing some testing on it today. |
Proposed changes
The scope of this PR includes:
Type of Change
Checklist
Further comments