Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct misbranded spelling of WonderBlocks and DOM ID dupe #1221

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

0aveRyan
Copy link
Contributor

@0aveRyan 0aveRyan commented Jul 29, 2024

Proposed changes

  • WonderBlocks branding correction made in module weeks before feature toggle launched
  • Copy-pasted ID fix to prevent ID duplication in DOM

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@0aveRyan 0aveRyan requested a review from wpalani July 29, 2024 23:22
@0aveRyan 0aveRyan mentioned this pull request Jul 29, 2024
4 tasks
Copy link

cypress bot commented Jul 29, 2024



Test summary

391 0 59 0Flakiness 0


Run details

Project Bluehost Brand Plugin
Status Passed
Commit b7a69b8
Started Jul 29, 2024 11:24 PM
Ended Jul 29, 2024 11:51 PM
Duration 26:40 💡
OS Linux Ubuntu -
Browser Chrome 126

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link

cypress bot commented Jul 29, 2024



Test summary

391 0 59 0Flakiness 0


Run details

Project Bluehost Brand Plugin
Status Passed
Commit d8f1726 ℹ️
Started Jul 30, 2024 12:09 AM
Ended Jul 30, 2024 12:33 AM
Duration 24:32 💡
OS Linux Ubuntu -
Browser Chrome 126

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@wpalani wpalani merged commit f141b88 into release/3.14.0 Jul 30, 2024
9 checks passed
@wpalani wpalani deleted the fix/wonderblocks-incorrect-brand-name branch July 30, 2024 02:05
@wpalani wpalani added this to the July 31 Release milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants