Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/ecommerce version 1.3.42 #1289

Merged
merged 4 commits into from
Sep 4, 2024
Merged

Conversation

ramyakrishnai
Copy link
Contributor

Proposed changes

The ecommerce version 1.3.42 has been updated with the removal of the default upsell option PRESS0-1873

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@ramyakrishnai ramyakrishnai changed the base branch from main to develop September 4, 2024 13:37
Copy link

cypress bot commented Sep 4, 2024

Bluehost Brand Plugin    Run #10112

Run Properties:  status check failed Failed #10112  •  git commit f2fe4271ff ℹ️: Merge 5da5f14795524f6f905e23d20997e0dd8da406a5 into 23a90f459b39ac836f7be98cc403...
Project Bluehost Brand Plugin
Branch Review update/ecommerce-version-1.3.42
Run status status check failed Failed #10112
Run duration 06m 13s
Commit git commit f2fe4271ff ℹ️: Merge 5da5f14795524f6f905e23d20997e0dd8da406a5 into 23a90f459b39ac836f7be98cc403...
Committer Ramya
View all properties for this run ↗︎

Test results
Tests that failed  Failures 4
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 121
View all changes introduced in this branch ↗︎

Tests for review

Failed  vendor/newfold-labs/wp-module-patterns/tests/cypress/integration/wonder-blocks.cy.js • 4 failed tests

View Output Video

Test Artifacts
WonderBlocks > WonderBlocks button exists Test Replay Screenshots Video
WonderBlocks > WonderBlocks button opens modal Test Replay Screenshots Video
WonderBlocks > Close buttons closes modal Test Replay Screenshots Video
WonderBlocks > ESC button closes modal too Test Replay Screenshots Video
Flakiness  tests/cypress/integration/help.cy.js • 1 flaky test

View Output Video

Test Artifacts
Help Page > Is Accessible Test Replay Screenshots Video

Copy link

cypress bot commented Sep 4, 2024

Bluehost Brand Plugin    Run #10092

Run Properties:  status check passed Passed #10092  •  git commit 5da5f14795: ecommerce version 1.3.42
Project Bluehost Brand Plugin
Branch Review update/ecommerce-version-1.3.42
Run status status check passed Passed #10092
Run duration 27m 42s
Commit git commit 5da5f14795: ecommerce version 1.3.42
Committer Ramya krishna
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 36
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 418
View all changes introduced in this branch ↗︎

@circlecube circlecube added this to the September 11 Release milestone Sep 4, 2024
@wpalani wpalani merged commit aa123fe into develop Sep 4, 2024
2 of 3 checks passed
@wpalani wpalani deleted the update/ecommerce-version-1.3.42 branch September 4, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants