PRESS0-2212: Import WP Solutions Banner on Home page #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diwanshuster
approved these changes
Sep 18, 2024
# Conflicts: # src/app/pages/home/index.js
|
Running full test matrix now that the code conflicts have been resolved: https://github.com/bluehost/bluehost-wordpress-plugin/actions/runs/10925458847 |
Bluehost Brand Plugin
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
Bluehost Brand Plugin
|
| Branch Review |
PRESS0-2212
|
| Run status |
|
| Run duration | 17m 49s |
| Commit |
|
| Committer | aratidgr8 |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
40
|
Flaky
|
0
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
85
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
tests/cypress/integration/home.cy.js • 6 failed tests
| Test | Artifacts | |
|---|---|---|
| Home Page > Is Accessible |
Test Replay
Screenshots
Video
|
|
| Home Page > Welcome Section Exists |
Test Replay
Screenshots
Video
|
|
| Home Page > Account Section Exists |
Test Replay
Screenshots
Video
|
|
| Home Page > Help Section Exists |
Test Replay
Screenshots
Video
|
|
| Home Page > Webinars Section Exists |
Test Replay
Screenshots
Video
|
|
| Home Page > Webinars Section Renders Correctly |
Test Replay
Screenshots
Video
|
|
tests/cypress/integration/navigation.cy.js • 3 failed tests
| Test | Artifacts | |
|---|---|---|
| Navigation > Logo Links to home |
Test Replay
Screenshots
Video
|
|
| Navigation > Main nav links properly navigates |
Test Replay
Screenshots
Video
|
|
| Navigation > Subnav links properly navigates |
Test Replay
Screenshots
Video
|
|
vendor/newfold-labs/wp-module-coming-soon/tests/cypress/integration/coming-soon.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Coming Soon > Has Coming Soon Section on Home |
Test Replay
Screenshots
Video
|
|
vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/ecommerce-coming-soon.cy.js • 4 failed tests
| Test | Artifacts | |
|---|---|---|
| e-commerce Home Page- Coming soon mode > Verify Congrats on your new site message, coming soon alert |
Test Replay
Screenshots
Video
|
|
| e-commerce Home Page- Coming soon mode > Verify Site Preview flex and View your site option |
Test Replay
Screenshots
Video
|
|
| e-commerce Home Page- Coming soon mode > Verify presense of Ready to go to live? canvas |
Test Replay
Screenshots
Video
|
|
| e-commerce Home Page- Coming soon mode > Verify Visit your site and Launch your site functionality |
Test Replay
Screenshots
Video
|
|
vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/ecommerce-live.cy.js • 2 failed tests
| Test | Artifacts | |
|---|---|---|
| e-commerce Home Page- Live Mode > Verify presense of Ready to go to next level? canvas |
Test Replay
Screenshots
Video
|
|
| e-commerce Home Page- Live Mode > Verify by default View Site option should be displayed |
Test Replay
Screenshots
Video
|
|
The first 5 failed specs are shown, see all 8 specs in Cypress Cloud.
|
@aratidgr8 Let's look into why so many tests are failing: https://github.com/bluehost/bluehost-wordpress-plugin/actions/runs/10925458847 |
|
@wpscholar we are checking why tests are failing will keep you posted on updates. Attaching JIRA for your reference. Thanks! |
8 tasks
|
The tests are failing because the ecommerce package is still on an older version, and the solutions banner import does not exist. |
@wpscholar As confirmed by @krsomayagi in comment tests will pass once home page banner PR is merged. Please confirm in that case are we good to merge this PR then? |
|
@aratidgr8 Yes, let's merge both of those |
circlecube
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
JIRA: https://jira.newfold.com/browse/PRESS0-2212
Import WP Solutions Banner Component on Home page.
Refer to PR for more details.
Type of Change
Checklist
Further comments