Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove revision settings UI and filter #1319

Merged
merged 6 commits into from
Sep 21, 2024
Merged

Remove revision settings UI and filter #1319

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9ff4c0b
Temporarily remove revision settings UI and filter
0aveRyan Sep 21, 2024
4085126
change lock file too
0aveRyan Sep 21, 2024
fea0193
Nix tests
0aveRyan Sep 21, 2024
16f0cae
Fully remove wp_revisions_to_keep method
0aveRyan Sep 21, 2024
7bea44f
Remove render of ContentRevisions
0aveRyan Sep 21, 2024
49f25d4
tests remove unused component
0aveRyan Sep 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bluehost-wordpress-plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
* Plugin URI: https://bluehost.com
* Update URI: https://github.com/bluehost/bluehost-wordpress-plugin
* Description: WordPress plugin that integrates a WordPress site with the Bluehost control panel, including performance, security, and update features.
* Version: 3.14.10
* Version: 3.14.11
* Requires at least: 6.4
* Requires PHP: 7.3
* Tested up to: 6.6.2
Expand All @@ -32,7 +32,7 @@
}

// Define constants
define( 'BLUEHOST_PLUGIN_VERSION', '3.14.10' );
define( 'BLUEHOST_PLUGIN_VERSION', '3.14.11' );
define( 'BLUEHOST_PLUGIN_FILE', __FILE__ );
define( 'BLUEHOST_PLUGIN_DIR', plugin_dir_path( __FILE__ ) );
define( 'BLUEHOST_PLUGIN_URL', plugin_dir_url( __FILE__ ) );
Expand Down
2 changes: 1 addition & 1 deletion inc/settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
function nfd_settings_revisions( $num, $post ) {
return get_option( 'nfd_wp_post_revisions', 5 );
}
add_filter( 'wp_revisions_to_keep', __NAMESPACE__ . '\\nfd_settings_revisions', 10, 2 );
0aveRyan marked this conversation as resolved.
Show resolved Hide resolved
// add_filter( 'wp_revisions_to_keep', __NAMESPACE__ . '\\nfd_settings_revisions', 10, 2 );

if ( ! defined( 'EMPTY_TRASH_DAYS' ) ) {
$nfd_empty_trash_days = get_option( 'nfd_empty_trash_days', 30 );
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "bluehost-wordpress-plugin",
"version": "3.14.10",
"version": "3.14.11",
"description": "WordPress plugin that integrates your WordPress site with the Bluehost control panel, including performance, security, and update features.",
"author": {
"name": "Bluehost",
Expand Down
2 changes: 1 addition & 1 deletion src/app/pages/settings/contentSettings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import { bluehostSettingsApiFetch } from 'App/util/helpers';
import { useNotification } from 'App/components/notifications';

const ContentRevisions = ( { setError, notify } ) => {

Check failure on line 8 in src/app/pages/settings/contentSettings.js

View workflow job for this annotation

GitHub Actions / ESLint 

'ContentRevisions' is assigned a value but never used
const { store, setStore } = useContext( AppStore );
const [ contentRevisions, setNumContentRevisions ] = useState(
store.contentRevisions
Expand Down Expand Up @@ -200,7 +200,7 @@
) }
>
<div className="nfd-flex nfd-flex-col nfd-gap-4">
<ContentRevisions setError={ setError } notify={ notify } />
{/* <ContentRevisions setError={ setError } notify={ notify } /> */}

Check failure on line 203 in src/app/pages/settings/contentSettings.js

View workflow job for this annotation

GitHub Actions / ESLint 

Replace `/*·<ContentRevisions·setError={·setError·}·notify={·notify·}·/>·*/` with `·/*·<ContentRevisions·setError={·setError·}·notify={·notify·}·/>·*/·`
<EmptyTrash setError={ setError } notify={ notify } />

{ isError && (
Expand Down
Loading