Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Onboarding to 2.5.0 #1364

Closed
wants to merge 1 commit into from
Closed

Conversation

officiallygod
Copy link
Contributor

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@officiallygod officiallygod self-assigned this Oct 23, 2024
@officiallygod officiallygod changed the base branch from main to feature/solutions October 23, 2024 13:02
Copy link

cypress bot commented Oct 23, 2024

Bluehost Brand Plugin    Run #11118

Run Properties:  status check failed Failed #11118  •  git commit 4a4dc08e49 ℹ️: Merge fb0ae45b1226ad56818eab6de74ad4097a9fd987 into 9dfc90b280105bbf7e0b9a845100...
Project Bluehost Brand Plugin
Branch Review update/onboarding-2.5.0
Run status status check failed Failed #11118
Run duration 33m 05s
Commit git commit 4a4dc08e49 ℹ️: Merge fb0ae45b1226ad56818eab6de74ad4097a9fd987 into 9dfc90b280105bbf7e0b9a845100...
Committer Allen Benny
View all properties for this run ↗︎

Test results
Tests that failed  Failures 119
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 17
Tests that did not run due to a failure in a mocha hook  Skipped 316
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎

Tests for review

Failed  help.cy.js • 9 failed tests

View Output Video

Test Artifacts
Help Page > Is Accessible Test Replay Screenshots Video
Help Page > Phone Card Exists Test Replay Screenshots Video
Help Page > Chat Card Exists Test Replay Screenshots Video
Help Page > Tweet Card Exists Test Replay Screenshots Video
Help Page > Youtube Card Exists Test Replay Screenshots Video
Help Page > Online Support Card Exists Test Replay Screenshots Video
Help Page > Resources Card Exists Test Replay Screenshots Video
Help Page > Events Card Exists Test Replay Screenshots Video
Help Page > Website Card Exists Test Replay Screenshots Video
Failed  home.cy.js • 1 failed test

View Output Video

Test Artifacts
Home Page > Site Info Exists Test Replay Screenshots Video
Failed  navigation.cy.js • 1 failed test

View Output Video

Test Artifacts
Navigation > Admin submenu shouldn't exist inside app Test Replay Screenshots Video
Failed  pages-and-posts.cy.js • 1 failed test

View Output Video

Test Artifacts
Pages & Posts > Pages & Posts Exists Test Replay Screenshots Video
Failed  settings.cy.js • 15 failed tests

View Output Video

Test Artifacts
Settings Page > Is Accessible Test Replay Screenshots Video
Settings Page > Has Coming Soon Test Replay Screenshots Video
Settings Page > Has Auto Updates Settings Test Replay Screenshots Video
Settings Page > Has Content Settings Test Replay Screenshots Video
Settings Page > Has Comments Settings Test Replay Screenshots Video
Settings Page > On load update all is checked, which forces other updates to check and disabled state Test Replay Screenshots Video
Settings Page > Disable ALL toggle, leaves everything checked, but enables them Test Replay Screenshots Video
Settings Page > Core toggle works Test Replay Screenshots Video
Settings Page > Plugins toggle works Test Replay Screenshots Video
Settings Page > Themes toggle works Test Replay Screenshots Video
The first 10 failed tests are shown, see all 15 tests in Cypress Cloud.

The first 5 failed specs are shown, see all 59 specs in Cypress Cloud.

Copy link

cypress bot commented Oct 23, 2024

Bluehost Brand Plugin    Run #11099

Run Properties:  status check failed Failed #11099  •  git commit fb0ae45b12: update onboarding
Project Bluehost Brand Plugin
Branch Review update/onboarding-2.5.0
Run status status check failed Failed #11099
Run duration 33m 40s
Commit git commit fb0ae45b12: update onboarding
Committer Allen Benny
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 36
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 416
View all changes introduced in this branch ↗︎

Tests for review

Failed  vendor/newfold-labs/wp-module-migration/tests/cypress/integration/Migration/landIntoMigrationFromAM.cy.js • 1 failed test

View Output Video

Test Artifacts
Verify Migration- emulating AM flow > Verify Migration page is loaded Test Replay Screenshots Video
Flakiness  tests/cypress/integration/help.cy.js • 1 flaky test

View Output Video

Test Artifacts
Help Page > Is Accessible Test Replay Screenshots Video

circlecube
circlecube previously approved these changes Oct 23, 2024
Base automatically changed from feature/solutions to main October 24, 2024 01:48
@circlecube circlecube dismissed their stale review October 24, 2024 01:48

The base branch was changed.

@circlecube
Copy link
Member

This was included in the 3.15.0 release already, closing as it's now a duplicate PR.

@circlecube circlecube closed this Oct 24, 2024
@circlecube circlecube deleted the update/onboarding-2.5.0 branch October 24, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants