Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Installer Module to v1.2.1 #1368

Merged
merged 7 commits into from
Oct 25, 2024
Merged

Bump Installer Module to v1.2.1 #1368

merged 7 commits into from
Oct 25, 2024

Conversation

officiallygod
Copy link
Contributor

@officiallygod officiallygod commented Oct 25, 2024

Proposed changes

This uses the re-released installer module v 1.2.1 that has a fix for the version mismatch.

PR for fix: newfold-labs/wp-module-installer#41
Release Notes: https://github.com/newfold-labs/wp-module-installer/releases/tag/1.2.1

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@officiallygod officiallygod self-assigned this Oct 25, 2024
@officiallygod officiallygod changed the title Bump Installer Module Bump Installer Module to v1.2.1 Oct 25, 2024
Copy link

cypress bot commented Oct 25, 2024

Bluehost Brand Plugin    Run #11281

Run Properties:  status check failed Failed #11281  •  git commit f24e7e50a5 ℹ️: Merge 3b67d645b5195748857efecb0a8c0a3e564dfbd3 into 8de11aa981c4659ea883043a42c5...
Project Bluehost Brand Plugin
Branch Review update/installer-to-1.2.1
Run status status check failed Failed #11281
Run duration 28m 37s
Commit git commit f24e7e50a5 ℹ️: Merge 3b67d645b5195748857efecb0a8c0a3e564dfbd3 into 8de11aa981c4659ea883043a42c5...
Committer Allen Benny
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 36
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 415
View all changes introduced in this branch ↗︎

Tests for review

Failed  tests/cypress/integration/help.cy.js • 1 failed test

View Output Video

Test Artifacts
Help Page > Is Accessible Test Replay Screenshots Video

Copy link

cypress bot commented Oct 25, 2024

Bluehost Brand Plugin    Run #11271

Run Properties:  status check passed Passed #11271  •  git commit 3b67d645b5: Merge branch 'update/installer-to-1.2.1' of github.com:bluehost/bluehost-wordpre...
Project Bluehost Brand Plugin
Branch Review update/installer-to-1.2.1
Run status status check passed Passed #11271
Run duration 27m 27s
Commit git commit 3b67d645b5: Merge branch 'update/installer-to-1.2.1' of github.com:bluehost/bluehost-wordpre...
Committer Micah Wood
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 36
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 416
View all changes introduced in this branch ↗︎

@wpscholar wpscholar requested a review from circlecube October 25, 2024 13:41
Copy link
Member

@circlecube circlecube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that this is installing installer 1.2.2 in composer.lock.

@circlecube circlecube merged commit d3453c5 into main Oct 25, 2024
20 of 22 checks passed
@circlecube circlecube deleted the update/installer-to-1.2.1 branch October 25, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants