Fix 'isJarvis' check that always returned true #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bluehost Brand Plugin
|
||||||||||||||||||||||||||||
| Project |
Bluehost Brand Plugin
|
| Branch Review |
fix/isJarvis-check
|
| Run status |
|
| Run duration | 33m 55s |
| Commit |
|
| Committer | Evan Mullins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
32
|
Skipped
|
0
|
Passing
|
415
|
| View all changes introduced in this branch ↗︎ | |
Bluehost Brand Plugin
|
||||||||||||||||||||||||||||
| Project |
Bluehost Brand Plugin
|
| Branch Review |
fix/isJarvis-check
|
| Run status |
|
| Run duration | 34m 37s |
| Commit |
|
| Committer | Allen Benny |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
2
|
|
Pending
|
32
|
|
Skipped
|
0
|
|
Passing
|
415
|
| View all changes introduced in this branch ↗︎ | |
arunshenoy99
previously approved these changes
Dec 10, 2024
circlecube
dismissed
arunshenoy99’s stale review
The base branch was changed.
circlecube
approved these changes
Dec 11, 2024
* develop: NPM(deps): Bump @wordpress/dom-ready from 4.13.0 to 4.14.0 NPM(deps): Bump react-use from 17.5.1 to 17.6.0 Composer(deps): Bump newfold-labs/wp-module-data from 2.6.7 to 2.6.8 minor composer dependency updates update plugin version to 3.15.7 also include npm i to update package lock file with new version alpha order command add cleanup, build and i18n to npm command too update plugin file in version bump script too update package.json version with a script NPM Dev(deps-dev): Bump cypress from 13.16.0 to 13.16.1 NPM(deps): Bump @heroicons/react from 2.1.5 to 2.2.0 NPM Dev(deps-dev): Bump tailwindcss from 3.4.15 to 3.4.16 NPM(deps): Bump @wordpress/i18n from 5.12.0 to 5.13.0 NPM(deps): Bump react-router-dom from 6.28.0 to 7.0.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: The
isJarvisCheck that is defined in the helper util function checks forbluehost-wordpress-plugin/src/app/util/helpers.js
Line 226 in b12e1d7
Due to this even if the isJarvis capability is switched off in a prod site, the
isJarvis functionreturned true, as the if case inside the function fails and the default return is true.This created an issue where in Bluehost_India customers the link to Bluehost Account in the plugin was incorrect. PRESS0-2354
Type of Change
Checklist
Further comments