Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Performance to 2.1.0 #1481

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Bump Performance to 2.1.0 #1481

merged 5 commits into from
Dec 18, 2024

Conversation

arunshenoy99
Copy link
Member

@arunshenoy99 arunshenoy99 commented Dec 17, 2024

Proposed changes

Adds: Link Prefetch Settings

imagen imagen

Depending on the selected options, the frontend js will manage the behaviour of this feature as explained in the options description texts. It will add a link rel=prefetch tag in the page header.

imagen

On Desktop:

  1. Prefetch on Mouse Hover (Recommended): the js will add the link tag after 60ms of the mouse hover so the broswer will prefetch and the link and when the actual redirection happen the loading will be faster.
  2. Prefetch on Mouse down: normally the click on a link really happens when the mouse button is released, and not when the button is pressed as one could imagine. So with this option we start to prefetch the link as soon as the mouse button is pressed.

On Mobile:

  1. Prefetch on Touchstart (Recommended): it is like the Mouse down option for desktop.
  2. Prefetch Above the Fold: in this case the js will prefetch all the links in the current view

Adds: Jetpack Boost Settings

Screen-2024-11-11-134622.mp4

Fixes: Caching button in the admin bar not visible

imagen

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Release: https://github.com/newfold-labs/wp-module-performance/releases/tag/2.1.0

Copy link

cypress bot commented Dec 17, 2024

Bluehost Brand Plugin    Run #12424

Run Properties:  status check failed Failed #12424  •  git commit 184815028d: Merge branch 'develop' into update/performance
Project Bluehost Brand Plugin
Branch Review update/performance
Run status status check failed Failed #12424
Run duration 35m 14s
Commit git commit 184815028d: Merge branch 'develop' into update/performance
Committer Evan Mullins
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 33
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 409
View all changes introduced in this branch ↗︎

Tests for review

Failed  vendor/newfold-labs/wp-module-solutions/tests/cypress/integration/solutions-app.cy.js • 1 failed test

View Output Video

Test Artifacts
My Plugins and Tools in Plugin App > My Plugins & Tools displays with Solution Test Replay Screenshots Video
Flakiness  vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/2-general-onboarding-flow/basic-info.cy.js • 1 flaky test

View Output Video

Test Artifacts
Basic Info Page > Check Drawer Activity Test Replay Screenshots Video
Flakiness  vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/3-ecommerce-onboarding-flow/basic-info.cy.js • 1 flaky test

View Output Video

Test Artifacts
Basic Info Page > Check Drawer Activity Test Replay Screenshots Video

Copy link

cypress bot commented Dec 17, 2024

Bluehost Brand Plugin    Run #12414

Run Properties:  status check passed Passed #12414  •  git commit f961d9a539 ℹ️: Merge e8d224940f459093cd63f7ec2428b4bea2b8eedc into fd4c0c1bf2c044e7bdbc5c4b0371...
Project Bluehost Brand Plugin
Branch Review update/performance
Run status status check passed Passed #12414
Run duration 32m 19s
Commit git commit f961d9a539 ℹ️: Merge e8d224940f459093cd63f7ec2428b4bea2b8eedc into fd4c0c1bf2c044e7bdbc5c4b0371...
Committer Arun Shenoy
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 32
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 415
View all changes introduced in this branch ↗︎

@circlecube circlecube added this to the January 8, 2025 Release milestone Dec 17, 2024
* develop:
  ecommerce and help center version bumps
  Update description to mention PR due date is a week before
  NPM(deps): Bump @wordpress/icons from 10.13.0 to 10.14.0
  NPM(deps): Bump @wordpress/element from 6.13.0 to 6.14.0
  run npm audit fix
  npm run set-version-bump - Version updated 3.15.7 => 3.15.8

# Conflicts:
#	composer.lock
* develop:
  Composer(deps): Bump newfold-labs/wp-module-coming-soon
  Composer(deps): Bump newfold-labs/wp-module-deactivation

# Conflicts:
#	composer.lock
@circlecube circlecube merged commit d46b6f9 into develop Dec 18, 2024
1 of 3 checks passed
@circlecube circlecube deleted the update/performance branch December 18, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants