Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update runtime to npmjs #1506

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update runtime to npmjs #1506

wants to merge 2 commits into from

Conversation

circlecube
Copy link
Member

Proposed changes

This updates the runtime package to the newly hosted npmjs build. Migrating from github package to npmjs package will remove the token requirement and allow workflows to perform more often as expected. Currently, they often fail due to no token being found (for dependabot and in forked repos outside the newfold-labs org).

This updates the package and its imports.

See PRESS10-73 and PRESS10-63 for more details.

Also, see runtime package updates for this change:

And a similar PR on the e-commerce module doing the same thing:

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube self-assigned this Jan 8, 2025
@circlecube circlecube added this to the January 15, 2025 Release milestone Jan 8, 2025
Copy link

cypress bot commented Jan 8, 2025

Bluehost Brand Plugin    Run #12550

Run Properties:  status check passed Passed #12550  •  git commit 36bdced3d9: install runtime from npmjs
Project Bluehost Brand Plugin
Branch Review update/runtime-npmjs
Run status status check passed Passed #12550
Run duration 32m 09s
Commit git commit 36bdced3d9: install runtime from npmjs
Committer Evan Mullins
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 33
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 410
View all changes introduced in this branch ↗︎

Copy link

cypress bot commented Jan 8, 2025

Bluehost Brand Plugin    Run #12568

Run Properties:  status check passed Passed #12568  •  git commit 804c05c357 ℹ️: Merge 36bdced3d9f8a0d7cb7d98de8a99f4ab7e7e609d into d25d8826c015e354de0a70b44115...
Project Bluehost Brand Plugin
Branch Review update/runtime-npmjs
Run status status check passed Passed #12568
Run duration 30m 27s
Commit git commit 804c05c357 ℹ️: Merge 36bdced3d9f8a0d7cb7d98de8a99f4ab7e7e609d into d25d8826c015e354de0a70b44115...
Committer Evan Mullins
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 33
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 399
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant