-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Newfold Runtime Updates #708
Conversation
php-7.1, wp-6.19 replays were recorded for 175f918. 9 Failed
php-7.2, wp-6.19 replays were recorded for 175f918. 9 Failed
php-7.4, wp-6.19 replays were recorded for 175f918. 9 Failed
php-8.0, wp-6.19 replays were recorded for 175f918. 9 Failed
php-8.1, wp-6.19 replays were recorded for 175f918. 9 Failed
php-8.2, wp-6.19 replays were recorded for 175f918. 9 Failed
|
@@ -27,8 +27,8 @@ public function __construct() { | |||
/* Add inline style to hide subnav link */ | |||
\add_action( 'admin_head', array( __CLASS__, 'admin_nav_style' ) ); | |||
|
|||
\add_filter('newfold-runtime', array( __CLASS__, 'add_to_runtime' ) ); | |||
\add_filter('newfold_runtime', array( __CLASS__, 'add_to_runtime' ) ); | |||
\add_filter( 'newfold-runtime', array( __CLASS__, 'add_to_runtime' ) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need both of these in place? I believe newfold_runtime
replaced newfold-runtime
.
A single failing test is in the coming soon module, but a fix is already coming for that, so this PR is cleared. |
Proposed changes
Due to recent changes in the currently untagged Newfold Runtime (see newfold-labs/wp-module-runtime#14), it is now necessary to explicitly add
nfd-runtime
as a script dependency to the Bluehost plugin's main script file. The change on the runtime module allows the Newfold runtime to be loaded in scenarios where the main Bluehost script file is not.Type of Change