Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deactivation module #721

Merged
merged 1 commit into from
Oct 10, 2023
Merged

add deactivation module #721

merged 1 commit into from
Oct 10, 2023

Conversation

circlecube
Copy link
Member

Proposed changes

This adds the deactivation module as well as automated cypress tests to ensure that it functions properly. The deactivate link for this plugin now opens a modal and requests user feedback on why they are deactivating the plugin. The modal can be canceled, skipped, and submitted with a user-generated reason (which is submitted as event data), all of which have tests in place.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube self-assigned this Oct 10, 2023
@circlecube circlecube merged commit 2a59c24 into develop Oct 10, 2023
3 checks passed
@circlecube circlecube deleted the add/deactivation-module branch October 10, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants