Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update onboarding module to 1.11.2 #722

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Conversation

circlecube
Copy link
Member

Proposed changes

This updates the onboarding module from 1.10.4 to 1.11.2. Lots of changes which can be found here: newfold-labs/wp-module-onboarding@1.10.4...1.11.2

I'm looking for cypress tests to pass before merging.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

  - Upgrading newfold-labs/wp-module-onboarding (1.10.4 => 1.11.2)
  - Locking newfold-labs/wp-module-onboarding-data (0.0.3)
@circlecube
Copy link
Member Author

circlecube commented Oct 10, 2023

It looks like we need to coordinate the wp-module-onboarding-data versions. The onboarding module requires 0.0.3 and the e-commerce module requires 0.0.2. I believe we'll need to tag a new release of e-commerce to bump the wp-module-onboarding-data? I'm not familiar with the differences in the two versions though and I hope they are compatible.

@circlecube
Copy link
Member Author

Composer messages:

Your requirements could not be resolved to an installable set of packages.

Problem 1
- Root composer.json requires newfold-labs/wp-module-ecommerce ^1.3.0 -> satisfiable by newfold-labs/wp-module-ecommerce[v1.3.0].
- You can only install one version of a package, so only one of these can be installed: newfold-labs/wp-module-onboarding-data[0.0.2, 0.0.3].
- newfold-labs/wp-module-onboarding 1.11.2 requires newfold-labs/wp-module-onboarding-data ^0.0.3 -> satisfiable by newfold-labs/wp-module-onboarding-data[0.0.3].
- newfold-labs/wp-module-ecommerce v1.3.0 requires newfold-labs/wp-module-onboarding-data ^0.0.2 -> satisfiable by newfold-labs/wp-module-onboarding-data[0.0.2].
- Root composer.json requires newfold-labs/wp-module-onboarding ^1.11.2 -> satisfiable by newfold-labs/wp-module-onboarding[1.11.2].

@circlecube
Copy link
Member Author

Also, as noted in #714 we're looking for details in the PR and recording(s).

* develop:
  Remove previously commented out line
  Change `runtimeData` to `NewfoldRuntime` to match the window
  composer validate
  Remove "Additional Features" section from the app home page.

# Conflicts:
#	composer.lock
@circlecube
Copy link
Member Author

I've pulled in the updated 1.3.1 e-commerce module to fix the composer dependency mismatch.

@circlecube circlecube merged commit 99c83b2 into develop Oct 11, 2023
2 checks passed
@circlecube circlecube deleted the update/onboarding-module branch October 11, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants