Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ecommerce module to 1.3.0 #723

Closed
wants to merge 1 commit into from
Closed

update ecommerce module to 1.3.0 #723

wants to merge 1 commit into from

Conversation

circlecube
Copy link
Member

Proposed changes

Copied #717 so that tests would run in the PR just to make sure. If they pass here I'll merge.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube self-assigned this Oct 10, 2023
@circlecube circlecube requested a review from wpalani October 10, 2023 22:37
@circlecube circlecube mentioned this pull request Oct 10, 2023
Merged
8 tasks
@circlecube
Copy link
Member Author

Merged #717 so this is now redundant. Closing.

@circlecube circlecube closed this Oct 10, 2023
@circlecube circlecube deleted the update/ecommerce-module branch October 10, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpalani wpalani Awaiting requested review from wpalani

Assignees

@circlecube circlecube

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@circlecube