Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes skeletion loading issue in Onboarding #730

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

arunshenoy99
Copy link
Member

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

https://github.com/newfold-labs/wp-module-onboarding/releases/tag/1.11.3

@arunshenoy99
Copy link
Member Author

Before: There is a white space on the screen, before the skeleton loads up

before.mov

After: Skeleton loads up immediately

after.mov

@circlecube circlecube self-requested a review October 12, 2023 14:49
@circlecube circlecube merged commit dc64d41 into release/3.4 Oct 12, 2023
3 checks passed
@circlecube circlecube deleted the update/onboarding branch October 12, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants