Register admin submenu exclusively outside the app

[wpalani]

Proposed changes

This PR addresses this internal ticket: https://jira.newfold.com/projects/PRESS1/issues/PRESS1-175

Demo

Bluehost-admin-nav.mp4

Type of Change

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)

Checklist

• I have read the CONTRIBUTING doc
• Linting and tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Further comments

[replay-io]

1 replays were recorded for a66a0fb.

1 Failed

• vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/3-ecommerce-onboarding-flow/site-features.cy.js

  1. Check if Header and Subheader shows up

     AssertionError: Timed out retrying after 4000ms: Expected to find element: `.nfd-main-heading__title`, but never found it.
         at CheckHeadingSubheading (webpack:///./vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/wp-module-support/header.cy.js:14:38)
         at Context.eval (webpack:///./vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/3-ecommerce-onboarding-flow/site-features.cy.js:20:25)

  2. Check if Header and Subheader shows up

     AssertionError: Timed out retrying after 4000ms: Expected to find element: `.nfd-main-heading__title`, but never found it.
         at CheckHeadingSubheading (webpack:///./vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/wp-module-support/header.cy.js:14:38)
         at Context.eval (webpack:///./vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/3-ecommerce-onboarding-flow/site-features.cy.js:20:25)

  3. Check Drawer Activity
  4. Check to make sure sidebar opens, content is in place and close sidebar

     AssertionError: Timed out retrying after 4000ms: Expected to find element: `.nfd-onboarding-header__end > .components-button`, but never found it.
         at CheckIntroPanel (webpack:///./vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/wp-module-support/sidebar.cy.js:5:4)
         at Context.eval (webpack:///./vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/3-ecommerce-onboarding-flow/site-features.cy.js:33:19)

  5. Check to make sure sidebar opens, content is in place and close sidebar

     AssertionError: Timed out retrying after 4000ms: Expected to find element: `.nfd-onboarding-header__end > .components-button`, but never found it.
         at CheckIntroPanel (webpack:///./vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/wp-module-support/sidebar.cy.js:5:4)
         at Context.eval (webpack:///./vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/3-ecommerce-onboarding-flow/site-features.cy.js:33:19)

  6. Check if Site Features list exists and select them

     AssertionError: Timed out retrying after 4000ms: Expected to find element: `.checkbox-item `, but never found it.
         at Context.eval (webpack:///./vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/3-ecommerce-onboarding-flow/site-features.cy.js:42:17)

  7. Check if Site Features list exists and select them

     AssertionError: Timed out retrying after 4000ms: Expected to find element: `.checkbox-item `, but never found it.
         at Context.eval (webpack:///./vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/3-ecommerce-onboarding-flow/site-features.cy.js:42:17)

0 Passed

View test run on Replay ↗︎