Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bluehost logo not appearing on Safari #735

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

wpalani
Copy link
Member

@wpalani wpalani commented Oct 12, 2023

Proposed changes

This PR addresses this internal ticket: https://jira.newfold.com/projects/PRESS1/issues/PRESS1-177

Fix: add width and height classes to the Brand component (logo) to fix the logo not showing on browsers that require explicit width value on svgs.

Demo

fix-logo-safari

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube merged commit b259ff3 into develop Oct 13, 2023
3 checks passed
@circlecube circlecube deleted the fix/bluehost-logo-safari branch October 13, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants