Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump up help center to include brand compatibility #746

Closed
wants to merge 1 commit into from
Closed

bump up help center to include brand compatibility #746

wants to merge 1 commit into from

Conversation

amartya-dev
Copy link
Contributor

@amartya-dev amartya-dev commented Oct 19, 2023 •
edited
Loading

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@amartya-dev
Copy link
Contributor Author

The changes include the changes in the PRs of the following help center releases, they have the required screenshots for reference, basically:

  • supports translation
  • removes feedback if we cannot answer the question
  • adds support for multi brand

https://github.com/newfold-labs/wp-module-help-center/releases/tag/1.0.20
https://github.com/newfold-labs/wp-module-help-center/releases/tag/1.0.19

@circlecube circlecube changed the base branch from main to develop October 20, 2023 15:55
@circlecube circlecube self-requested a review October 20, 2023 15:55
@amartya-dev
Copy link
Contributor Author

@circlecube I think we can go with the PR by depandabot #750

This one is for the main branch which I think is the reason for the tests failing

@circlecube
Copy link
Member

Yes, thanks I've got it in #757

@circlecube circlecube closed this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@circlecube circlecube circlecube approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amartya-dev @circlecube