Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate that tested version matches the wp-env version #758

Merged

Conversation

circlecube
Copy link
Member

Proposed changes

PRESS1-192

Not sure if there's a good way to also check the https://api.wordpress.org/core/stable-check/1.0/ endpoint to get the latest version and make sure we're current too.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube requested a review from wpscholar October 20, 2023 17:24
@circlecube circlecube self-assigned this Oct 20, 2023
@wpscholar
Copy link
Member

@circlecube If we set up Node and did an NPM install first, it would auto-update the .wp-env.json file with the latest WP version. Then, we could do these steps right after that to leverage that updated value.

@circlecube
Copy link
Member Author

@wpscholar - Great point, I've moved this job to later in the workflow so the wp version should be at the latest.

@circlecube circlecube requested a review from wpscholar October 23, 2023 22:21
@circlecube circlecube merged commit 16b2255 into develop Oct 24, 2023
2 checks passed
@circlecube circlecube deleted the update/release-workflow-to-validate-wordpress-versions branch October 24, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants