Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coming soon admin notice link to include query strings #760

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

wpalani
Copy link
Member

@wpalani wpalani commented Oct 23, 2023

Proposed changes

Add &nfd-target=coming-soon-section#/settings to the coming soon admin notice to display the blink animation introduced in V3.4

This PR aims to address this internal ticket: https://jira.newfold.com/projects/PRESS1/issues/PRESS1-191

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube merged commit 855055e into develop Oct 23, 2023
5 checks passed
@circlecube circlecube deleted the update/comingsoon-admin-notice-url branch October 26, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants