Update/remove is jarvis host info file check #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
11 replays were recorded for 2e950a3.
|
wpscholar
approved these changes
Oct 30, 2023
…rue (for local and test envs)
wpscholar
approved these changes
Oct 30, 2023
|
Although, since the capabilities response requires a hiive connection we can't rely on it in test environments or even some local development envs. I've also created a helper method that checks the runtime capabilities object, but will fallback to a default true. Is this the best option we have? I think we should default isJarvis to true, since all sites are now migrated - we're just worried about sites that we are not hosting (or have lost a connection for some reason) not being able to get the capabilities, sites that are not migrated (IN for example, should have the false value in their response). |
|
@circlecube I think it makes sense to default to true for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This removes the
/.host-infojarvis check. This was only intended to be a temporary solution. Now we have the isJarvis check on hiive from the capabilities we can use instead. This removed the extraisJarvisvalues in the runtime object and container.It also stops referring to the value in the helper and account card components. It was checking the sdk.isJarvis value but this updates to using the
runtime.capabilities.isJarvisflag instead.There are also some other old references to values within the SDK object which are updated here so the plugin is not referencing the SDK object anywhere (though some modules may still be referencing it, we should completely audit that so we can remove the SDK object and the
nfd-runtimefilter from the plugins and then runtime module.Type of Change
Checklist
Further comments