Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update notifications module #800

Merged
merged 2 commits into from
Nov 14, 2023
Merged

update notifications module #800

merged 2 commits into from
Nov 14, 2023

Conversation

circlecube
Copy link
Member

Proposed changes

Updates notification module with the new required method and removing the resturl constant that is no longer used.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube self-assigned this Nov 13, 2023
Copy link

replay-io bot commented Nov 13, 2023

bluehost/bluehost-wordpress-plugin

StatusComplete ↗︎
Commit1497496
Results
2 Failed
  • tests/cypress/integration/help.cy.js
  • vendor/newfold-labs/wp-module-notifications/tests/cypress/integration/notifications.cy.js
      AssertionError: Timed out retrying after 4000ms: Expected to find element: `.newfold-notifications-wrapper #notification-test-4`, but never found it.
          at Context.eval (webpack:///./vendor/newfold-labs/wp-module-notifications/tests/cypress/integration/notifications.cy.js:96:13)
      AssertionError: Timed out retrying after 4000ms: Expected to find element: `.newfold-notifications-wrapper #notification-test-1`, but never found it.
          at Context.eval (webpack:///./vendor/newfold-labs/wp-module-notifications/tests/cypress/integration/notifications.cy.js:114:11)
      AssertionError: Timed out retrying after 4000ms: Expected to find element: `.newfold-notifications-wrapper #notification-test-2`, but never found it.
          at Context.eval (webpack:///./vendor/newfold-labs/wp-module-notifications/tests/cypress/integration/notifications.cy.js:142:11)
      AssertionError: Timed out retrying after 4000ms: Expected to find element: `.newfold-notifications-wrapper #notification-test-1`, but never found it.
          at Context.eval (webpack:///./vendor/newfold-labs/wp-module-notifications/tests/cypress/integration/notifications.cy.js:114:11)
      AssertionError: Timed out retrying after 4000ms: Expected to find element: `.newfold-notifications-wrapper #notification-test-4`, but never found it.
          at Context.eval (webpack:///./vendor/newfold-labs/wp-module-notifications/tests/cypress/integration/notifications.cy.js:96:13)
      AssertionError: Timed out retrying after 4000ms: Expected to find element: `.newfold-notifications-wrapper #notification-test-2`, but never found it.
          at Context.eval (webpack:///./vendor/newfold-labs/wp-module-notifications/tests/cypress/integration/notifications.cy.js:142:11)
26 Passed
  • tests/cypress/integration/home.cy.js
  • tests/cypress/integration/navigation.cy.js
  • tests/cypress/integration/settings.cy.js
  • tests/cypress/integration/version-check.cy.js
  • vendor/newfold-labs/wp-module-coming-soon/tests/cypress/integration/coming-soon.cy.js
  • vendor/newfold-labs/wp-module-ctb/tests/cypress/integration/ctb.cy.js
  • vendor/newfold-labs/wp-module-deactivation/tests/cypress/integration/deactivation-survey.cy.js
  • vendor/newfold-labs/wp-module-global-ctb/tests/cypress/integration/global-ctb.cy.js
  • vendor/newfold-labs/wp-module-marketplace/tests/cypress/integration/marketplace.cy.js
  • vendor/newfold-labs/wp-module-marketplace/tests/cypress/integration/premium-plugins-tab.cy.js
  • vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/1-Initial-steps/branding.cy.js
  • vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/1-Initial-steps/whats-next.cy.js
  • vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/2-general-onboarding-flow/get-started-experience.cy.js
  • vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/2-general-onboarding-flow/get-started-welcome.cy.js
  • vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/2-general-onboarding-flow/site-features.cy.js
  • vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/2-general-onboarding-flow/sitetype-primary.cy.js
  • vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/2-general-onboarding-flow/sitetype-secondary.cy.js
  • vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/2-general-onboarding-flow/top-priority.cy.js
  • vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/3-ecommerce-onboarding-flow/address.cy.js
  • vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/3-ecommerce-onboarding-flow/get-started-experience.cy.js
  • vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/3-ecommerce-onboarding-flow/products.cy.js
  • vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/3-ecommerce-onboarding-flow/sitetype-primary.cy.js
  • vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/3-ecommerce-onboarding-flow/sitetype-secondary.cy.js
  • vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/sidebar.cy.js
  • vendor/newfold-labs/wp-module-performance/tests/cypress/integration/performance.cy.js
  • vendor/newfold-labs/wp-module-staging/tests/cypress/integration/staging.cy.js

@circlecube circlecube changed the base branch from main to develop November 13, 2023 22:20
@circlecube circlecube merged commit 2adcaeb into develop Nov 14, 2023
2 checks passed
@circlecube circlecube deleted the update/notifications branch November 14, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants