Clean up the React app #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluehost/bluehost-wordpress-plugin
|
circlecube
reviewed
Nov 27, 2023
circlecube
reviewed
Nov 27, 2023
bradp
reviewed
Nov 28, 2023
bradp
reviewed
Nov 28, 2023
| description: __( | ||
| "Contact one of our friendly Customer Care Specialists, as we are waiting to help at " + getSupportPhoneNumber() + ". Open 24 hours - 7 days.", | ||
| `Contact one of our friendly Customer Care Specialists, as we are waiting to help at ${ getSupportPhoneNumber() }. Open 24 hours - 7 days.`, |
There was a problem hiding this comment.
Should we replace the hyphen with an en (–) or em (—) dash? Pedantically I think that is more appropriate, but also this is a very minor nitpick.
bradp
reviewed
Nov 28, 2023
bradp
reviewed
Nov 28, 2023
| 'wp-plugin-bluehost')} | ||
| title={ __( 'Help', 'wp-plugin-bluehost' ) } | ||
| subTitle={ __( | ||
| 'We are available 24/7 to help answer questions and solve your problems.', |
There was a problem hiding this comment.
We use "24 hours - 7 days" elsewhere, should these be consistent?
If this text comes from marketing or somewhere else, feel free to ignore.
bradp
reviewed
Nov 28, 2023
src/app/pages/home/helpCard.js
Outdated
| /> | ||
| <p>From DIY to full-service help.</p> | ||
| <p> | ||
| Call or chat 24/7 for support or let our experts build |
There was a problem hiding this comment.
🔢 "24/7" vs "24 hours - 7 days"
bradp
reviewed
Nov 28, 2023
bradp
reviewed
Nov 28, 2023
bradp
reviewed
Nov 28, 2023
Comment on lines
+26
to
+31
| 'Oops, there was an error loading the marketplace, please try again later.', | ||
| 'bluehost-wordpress-plugin' | ||
| ), | ||
| noProducts: __( | ||
| 'Sorry, no marketplace items. Please, try again later.', | ||
| 'bluehost-wordpress-plugin' |
There was a problem hiding this comment.
Can we make the "Please try again later" consistent?
I'd suggest , please try again later. for both.
bradp
reviewed
Nov 28, 2023
| 'bluehost-wordpress-plugin' | ||
| ), | ||
| noProducts: __( | ||
| 'Sorry, no marketplace items. Please, try again later.', |
There was a problem hiding this comment.
Can we change this to "Sorry, no marketplace items found" to be more clear?
bradp
reviewed
Nov 28, 2023
| <SectionHeader | ||
| title={ __( 'Performance', 'wp-plugin-bluehost' ) } | ||
| subTitle={ __( | ||
| 'This is where you can manage cache settings for your website.', |
There was a problem hiding this comment.
Is the "This is where you" necessary?
Maybe simplify to "Manage your website's cache settings"?
bradp
reviewed
Nov 28, 2023
| 'Coming soon page is active. Site requires login.', | ||
| 'wp-plugin-bluehost' | ||
| ) | ||
| 'Coming soon page is active. Site requires login.', |
There was a problem hiding this comment.
Suggested change
| 'Coming soon page is active. Site requires login.', | |
| 'Coming soon page is active. Site is only accessible to logged in users.', |
bradp
reviewed
Nov 28, 2023
| 'Coming soon page is not active. Site is live to visitors.', | ||
| 'wp-plugin-bluehost' | ||
| ); | ||
| 'Coming soon page is not active. Site is live to visitors.', |
There was a problem hiding this comment.
Suggested change
| 'Coming soon page is not active. Site is live to visitors.', | |
| 'Coming soon page is not active. Site is public and accessible to all visitors.', |
bradp
reviewed
Nov 28, 2023
| <Alert variant="info"> | ||
| {__('Your website is currently displaying a "Coming Soon" page.', 'wp-plugin-bluehost')} | ||
| { __( | ||
| 'Your website is currently displaying a "Coming Soon" page.', |
There was a problem hiding this comment.
Suggested change
| 'Your website is currently displaying a "Coming Soon" page.', | |
| 'Your site is currently displaying a "Coming Soon" page.', |
If we prefer "website", then there's a few other places we should update from "site" → "website" for consistency.
bradp
reviewed
Nov 28, 2023
| <Alert variant="error"> | ||
| {__('Oops! Something went wrong. Please try again.', 'wp-plugin-bluehost')} | ||
| { __( | ||
| 'Oops! Something went wrong. Please try again.', |
There was a problem hiding this comment.
🔢 Related to previous comments about "please try again", let's have this match whatever gets decided there.
bradp
reviewed
Nov 28, 2023
Comment on lines
+84
to
+92
| 'Comments on posts are disabled after ', | ||
| 'wp-plugin-bluehost' | ||
| ) + | ||
| closeCommentsDays + | ||
| _n(' day.', ' days.', parseInt(closeCommentsDays), 'wp-plugin-bluehost') | ||
| _n( | ||
| ' day.', | ||
| ' days.', | ||
| parseInt( closeCommentsDays ), | ||
| 'wp-plugin-bluehost' |
There was a problem hiding this comment.
This should be using sprintf to fill the closeCommentsDays and the day/days, not all languages will follow the same grammatical format as English.
bradp
reviewed
Nov 28, 2023
| <SectionHeader | ||
| title={ __( 'Settings', 'wp-plugin-bluehost' ) } | ||
| subTitle={ __( | ||
| 'This is where you can manage common settings for your website.', |
There was a problem hiding this comment.
🔢 "this is where you can manage X" vs "Manage X"
bradp
reviewed
Nov 28, 2023
bradp
reviewed
Nov 28, 2023
bradp
reviewed
Nov 28, 2023
bradp
reviewed
Nov 28, 2023
| nextWebinar.hasTime = nextWebinar.time ? true : false; | ||
| nextWebinar.link = nextWebinar.link ?? 'https://www.bluehost.com/blog/events/'; | ||
| nextWebinar.link = | ||
| nextWebinar.link ?? 'https://www.bluehost.com/blog/events/'; | ||
| nextWebinar.ctaText = nextWebinar.ctaText ?? 'Register Now'; |
There was a problem hiding this comment.
🔢 Need to make this translatable
bradp
reviewed
Nov 28, 2023
src/app/pages/home/helpCard.js
Outdated
| src={ SupportIllustration } | ||
| alt="Help Agent Illustration" | ||
| /> | ||
| <p>From DIY to full-service help.</p> |
There was a problem hiding this comment.
🔢 Need to make this translatable
There was a problem hiding this comment.
Addressed in this commit: f2189f1
bradp
reviewed
Nov 28, 2023
| <Alert variant="error"> | ||
| {__('Oops! Something went wrong. Please try again.', 'wp-plugin-bluehost')} | ||
| { __( | ||
| 'Oops! Something went wrong. Please try again.', |
There was a problem hiding this comment.
🔢 please try again consistency
bradp
reviewed
Nov 28, 2023
|
|
||
| /** | ||
| * Wrapper method to dispatch snackbar notice | ||
| * | ||
| * @param string text text for notice | ||
| * @param text | ||
| * @param {string} text text for notice |
There was a problem hiding this comment.
Suggested change
| * @param {string} text text for notice | |
| * @param {string} text Text for notice. |
bradp
reviewed
Nov 28, 2023
Comment on lines
+32
to
+34
| * @param {Object} data object of data | ||
| * @param {Function} passError setter for the error in component | ||
| * @param {Function} thenCallback method to call in promise then |
There was a problem hiding this comment.
Suggested change
| * @param {Object} data object of data | |
| * @param {Function} passError setter for the error in component | |
| * @param {Function} thenCallback method to call in promise then | |
| * @param {Object} data Object of data. | |
| * @param {Function} passError Setter for the error in component. | |
| * @param {Function} thenCallback Method to call in promise then. |
bradp
reviewed
Nov 28, 2023
Comment on lines
+54
to
+56
| * @param {Object} data object of data | ||
| * @param {Function} passError setter for the error in component | ||
| * @param {Function} thenCallback method to call in promise then |
There was a problem hiding this comment.
Suggested change
| * @param {Object} data object of data | |
| * @param {Function} passError setter for the error in component | |
| * @param {Function} thenCallback method to call in promise then | |
| * @param {Object} data Object of data. | |
| * @param {Function} passError Setter for the error in component. | |
| * @param {Function} thenCallback Method to call in promise then. |
bradp
reviewed
Nov 28, 2023
| comingsoonadminbar.style.color = "#E01C1C"; | ||
| comingsoonadminbar.textContent = "Coming Soon"; | ||
| comingsoonadminbar.style.color = '#E01C1C'; | ||
| comingsoonadminbar.textContent = 'Coming Soon'; |
|
@bradp Thanks for your feedback. I addressed some of your comments in this commit: f2189f1 I think most of what's left is a language/copy change that we should address in a different PR in a more thought-out way. Since this language is being used across other brand plugins, so we don't have to go back and change it again. |
Add some pizzazz to the "Welcome to Bluehost" console.log
…eaner-imports * update/react-app-cleanup: Fix minor ESLint issue after PR merge Translate strings Fix linting Update console ascii art Update eslint.yml Remove example page Add php dependencies to eslint action Move handlePageLoad function to react hook ESLint action Fix webinar banner component lint issue Other lint fixes Add `eslint` and lint js files # Conflicts: # src/app/data/routes.js # webpack.config.js
…mports Add module alias for cleaner imports
circlecube
approved these changes
Nov 30, 2023
1 flaky test on run #5511 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Help Page > Is Accessible |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #820 ↗︎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Since we moved a little bit quickly in 3.0 release, we didn't have enough time to clean up old code and structure the app properly, also we received new components/code from other teams with little time to give feedback. This PR aims to clean up the code of the React app including:
plugin:@wordpress/eslint-plugin/recommended.Todo:
Type of Change
Checklist
Further comments