-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/use newfold UI container component #850
Merged
circlecube
merged 7 commits into
release/3.7.0
from
update/use-newfold-ui-container-component
Dec 5, 2023
Merged
Update/use newfold UI container component #850
circlecube
merged 7 commits into
release/3.7.0
from
update/use-newfold-ui-container-component
Dec 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix minor react content error due to incorrect prop key name
Bump Marketplace, Staging and Performance modules versions.
…ewfold-ui-container-component
5 failed and 1 flaky tests on run #5691 ↗︎
Details:
vendor/newfold-labs/wp-module-patterns/tests/cypress/integration/wonder-blocks.cy.js • 4 failed testsvendor/newfold-labs/wp-module-staging/tests/cypress/integration/staging.cy.js • 1 failed test
tests/cypress/integration/help.cy.js • 1 flaky test
Review all test suite changes for PR #850 ↗︎ |
circlecube
approved these changes
Dec 5, 2023
Merging this in as is and will work on fixing the tests in the release branch, since at least one is already failing there anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR aims to continue the effort to clean up the React app as reported in this internal ticket: 1-241
Summary:
Type of Change
Checklist
Further comments