Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/use newfold UI container component #850

Merged
merged 7 commits into from
Dec 5, 2023

Conversation

wpalani
Copy link
Member

@wpalani wpalani commented Dec 5, 2023

Proposed changes

This PR aims to continue the effort to clean up the React app as reported in this internal ticket: 1-241

Summary:

  • Replace local Section and Page components with Container and Page from Newfold UI 1.0.1
  • Bump modules that relied on these local components and now using Newfold UI as well.
  • Introduce a new useContainerBlockTarget React hook to be used for target section flashing.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

cypress bot commented Dec 5, 2023

5 failed and 1 flaky tests on run #5691 ↗︎

5 240 57 0 Flakiness 1

Details:

Merge 1988c0b into 42ae9ec...
Project: Bluehost Brand Plugin Commit: 6b5c3aba3e ℹ️
Status: Failed Duration: 15:47 💡
Started: Dec 5, 2023 4:10 PM Ended: Dec 5, 2023 4:25 PM
Failed  vendor/newfold-labs/wp-module-patterns/tests/cypress/integration/wonder-blocks.cy.js • 4 failed tests

View Output Video

Test Artifacts
Wonder Blocks > Wonder Blocks button exists Test Replay Screenshots Video
Wonder Blocks > Wonder Blocks button opens modal Test Replay Screenshots Video
Wonder Blocks > Close buttons closes modal Test Replay Screenshots Video
Wonder Blocks > ESC button closes modal too Test Replay Screenshots Video
Failed  vendor/newfold-labs/wp-module-staging/tests/cypress/integration/staging.cy.js • 1 failed test

View Output Video

Test Artifacts
Staging Page > Create Works Screenshots Video
Flakiness  tests/cypress/integration/help.cy.js • 1 flaky test

View Output Video

Test Artifacts
Help Page > Is Accessible Test Replay Screenshots Video

Review all test suite changes for PR #850 ↗︎

@circlecube
Copy link
Member

Merging this in as is and will work on fixing the tests in the release branch, since at least one is already failing there anyways.

@circlecube circlecube merged commit c54940e into release/3.7.0 Dec 5, 2023
3 of 7 checks passed
@circlecube circlecube deleted the update/use-newfold-ui-container-component branch December 5, 2023 16:33
@cypress cypress bot mentioned this pull request Dec 5, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants