Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Onboarding to 1.12.0 #880

Closed
wants to merge 4 commits into from
Closed

Bump Onboarding to 1.12.0 #880

wants to merge 4 commits into from

Conversation

arunshenoy99
Copy link
Member

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

cypress bot commented Jan 16, 2024

2 failed and 2 flaky tests on run #6143 ↗︎

2 311 43 0 Flakiness 2

Details:

Merge 3a168dd into 1b8efa3...
Project: Bluehost Brand Plugin Commit: 6de88e8ab0 ℹ️
Status: Failed Duration: 21:34 💡
Started: Jan 16, 2024 8:39 AM Ended: Jan 16, 2024 9:00 AM
Failed  vendor/newfold-labs/wp-module-coming-soon/tests/cypress/integration/coming-soon.cy.js • 2 failed tests

View Output Video

Test Artifacts
Coming Soon > Coming Soon Toggle Functions Test Replay Screenshots Video
Coming Soon > Displays Coming Soon in Site Status Admin Toolbar Test Replay Screenshots Video
Flakiness  tests/cypress/integration/help.cy.js • 1 flaky test

View Output Video

Test Artifacts
Help Page > Is Accessible Test Replay Screenshots Video
Flakiness  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/commerceHomePage.cy.js • 1 flaky test

View Output Video

Test Artifacts
Commerce Home Page- Next Steps > Verify Next steps when experience level is novice Test Replay Screenshots Video

Review all test suite changes for PR #880 ↗︎

@circlecube
Copy link
Member

This will be addressed in #886 closing this to reduce PR noise.

@circlecube circlecube closed this Jan 17, 2024
@circlecube circlecube deleted the bump/onboarding branch January 17, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants