Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Press4-444 Update Coming Soon Toggle to match Figma Designs #906

Closed
wants to merge 2 commits into from

Conversation

mamatharao05
Copy link
Contributor

Updated the "Site Status" setting UI to match the Figma.

image

image

@circlecube circlecube self-requested a review January 26, 2024 18:14
Copy link
Member

@circlecube circlecube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve and merge this, but it will need some updates. The __() method needs a string rather than a ternary. I'll set up a new method on the component that will return the proper string as we do in other cases where the value depends on another var.

circlecube added a commit that referenced this pull request Jan 26, 2024
@circlecube
Copy link
Member

Actually, I made the relevant changes to the release branch #911 so this doesn't need to be merged. I didn't want to cause errors in the develop branch that would need fixing.

Thanks!

@circlecube circlecube closed this Jan 26, 2024
@cypress cypress bot mentioned this pull request Jan 26, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants