update node version in plugin, nvm and main workflows #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 flaky tests on run #6697 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Help Page > Is Accessible |
Test Replay
Screenshots
Video
|
|
vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/2-general-onboarding-flow/sitetype-primary.cy.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Get Started Site Type Primary > Check for Event API call being made when different categories are selected |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #914 ↗︎
2 flaky tests on run #6694 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Help Page > Is Accessible |
Test Replay
Screenshots
Video
|
|
vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/3-ecommerce-onboarding-flow/get-started-experience.cy.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Start Setup WP Experience Page > Check if events API call being made after radio buttons are clicked |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #914 ↗︎
* develop: Composer(deps): Bump newfold-labs/wp-module-onboarding
wpscholar
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This updates the node used in nvmrc file, the package.json file, updates wp-scripts (since it was locked at 26 due to node 16), and our main workflows (so far) that specified v16 use.
Expecting the build and tests to pass here.
Type of Change
Checklist
Further comments