Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Onboarding to 2.1.4 #962

Merged
merged 10 commits into from
Feb 28, 2024
Merged

Bump Onboarding to 2.1.4 #962

merged 10 commits into from
Feb 28, 2024

Conversation

officiallygod
Copy link
Contributor

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Release Notes:
https://github.com/newfold-labs/wp-module-onboarding/releases/tag/2.1.4

@officiallygod officiallygod self-assigned this Feb 28, 2024
@officiallygod officiallygod mentioned this pull request Feb 28, 2024
8 tasks
Copy link

cypress bot commented Feb 28, 2024

3 failed tests on run #7384 ↗︎

3 327 24 0 Flakiness 0

Details:

fix lock file
Project: Bluehost Brand Plugin Commit: e4e5e6e2f3
Status: Failed Duration: 19:30 💡
Started: Feb 28, 2024 6:25 PM Ended: Feb 28, 2024 6:44 PM
Failed  vendor/newfold-labs/wp-module-coming-soon/tests/cypress/integration/coming-soon.cy.js • 3 failed tests

View Output Video

Test Artifacts
Coming Soon > Coming Soon Toggle Functions Test Replay Screenshots Video
Coming Soon > Displays Coming Soon in Site Status Admin Toolbar Test Replay Screenshots Video
Coming Soon > Has Coming Soon Section on Home Test Replay Screenshots Video

Review all test suite changes for PR #962 ↗︎

Copy link

cypress bot commented Feb 28, 2024

6 failed and 1 flaky tests on run #7323 ↗︎

6 323 24 4 Flakiness 1

Details:

Merge 6769791 into a62af0d...
Project: Bluehost Brand Plugin Commit: 5075624fd8 ℹ️
Status: Failed Duration: 21:02 💡
Started: Feb 28, 2024 2:48 PM Ended: Feb 28, 2024 3:09 PM
Failed  vendor/newfold-labs/wp-module-coming-soon/tests/cypress/integration/coming-soon.cy.js • 3 failed tests

View Output Video

Test Artifacts
Coming Soon > Coming Soon Toggle Functions Test Replay Screenshots Video
Coming Soon > Displays Coming Soon in Site Status Admin Toolbar Test Replay Screenshots Video
Coming Soon > Has Coming Soon Section on Home Test Replay Screenshots Video
Failed  vendor/newfold-labs/wp-module-ctb/tests/cypress/integration/ctb.cy.js • 2 failed tests

View Output Video

Test Artifacts
Click to buy > CTB modal is functional Test Replay Screenshots Video
Click to buy > CTB purchase functions properly Test Replay Screenshots Video
Failed  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Site-Capabilities/siteCapabilities.cy.js • 1 failed test

View Output Video

Test Artifacts
Verify Wondercart accessibility as per site capabilities > Verify if Sales and Discounts sub tab is displayed Test Replay Screenshots Video
Flakiness  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/commerceHomePage.cy.js • 1 flaky test

View Output Video

Test Artifacts
Commerce Home Page- Next Steps > Verify Next steps when experience level is novice Test Replay Screenshots Video

Review all test suite changes for PR #962 ↗︎

@officiallygod officiallygod changed the base branch from release/3.9.0 to main February 28, 2024 14:44
@diwanshuster diwanshuster changed the base branch from main to release/3.9.0 February 28, 2024 15:51
officiallygod and others added 7 commits February 28, 2024 21:55
* release/3.9.0:
  remove call to legacy method that was removed for `site_id`
  Remove modules: Busines Reviews, Customer Bluehost data, Legacy CTB

# Conflicts:
#	composer.lock
@circlecube
Copy link
Member

Seeing coming soon failing here for some reason, but seeing the same in the release branch, so I'll merge this into one place and debug that in the release branch.

@circlecube circlecube merged commit 0624fab into release/3.9.0 Feb 28, 2024
1 of 3 checks passed
@cypress cypress bot mentioned this pull request Feb 28, 2024
8 tasks
@officiallygod officiallygod deleted the update/onboarding-2.1.4 branch March 1, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants