Skip to content
This repository has been archived by the owner on Feb 3, 2019. It is now read-only.

DateTimeField requires input even when there are no Required validators #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions datetimefield.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,13 @@ func (f *DateTimeFieldInstance) Clean(data Data) error {
v := m.rawValueAsString()
m.Kind = reflect.Struct
if v != nil {
t, err := time.Parse(f.Format, *v)
if err != nil {
return errors.New(f.ErrorMessage)
if *v != "" {
t, err := time.Parse(f.Format, *v)
if err != nil {
return errors.New(f.ErrorMessage)
}
m.Value = t
}
m.Value = t
m.IsNil = false
}
}
Expand Down
15 changes: 15 additions & 0 deletions datetimefield_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,3 +99,18 @@ func TestInputValidDateTimeFormat(t *testing.T) {
t.Error("given: " + obj.Date.String() + ", exptected: " + DefaultDateTimeFormat)
}
}

func TestInputDateNotRequired(t *testing.T) {
Form := DefineForm(NewFields(
NewDateTimeField("date", DefaultDateFormat, nil),
))
reqDate := ""
req, _ := http.NewRequest("POST", "/", strings.NewReader(url.Values{"date": {reqDate}}.Encode()))
req.Header.Add("Content-Type", "application/x-www-form-urlencoded")

form := Form(req)
if !form.IsValid() {
t.Error("Date required when it should not be.")
return
}
}