Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fastapi swagger documentation when offline #1568

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

patrickelectric
Copy link
Member

Fix #1209

@patrickelectric patrickelectric force-pushed the offline-doc branch 2 times, most recently from c12497d to 3241445 Compare March 29, 2023 19:36
Signed-off-by: Patrick José Pereira <[email protected]>
Necessary for fastapi-offline

Signed-off-by: Patrick José Pereira <[email protected]>
Necessary for fastapi 0.89.1

Signed-off-by: Patrick José Pereira <[email protected]>
@joaoantoniocardoso
Copy link
Member

Unable to test it here - blueos.local is not working and accessing it directly from its IP reveals an unstable system:

errors_pr_1568.mp4

And yes, blueos.local was up again when I switched back to master (tested both 00c53c40 and 44cdf7b4).

@patrickelectric
Copy link
Member Author

@joaoantoniocardoso that's not ready to review yet, I'm still finding some problems with the approach, the number of libraries that need to update got the system to behave a bit unstable. I'll add everybody on the review list once it's ready.

@patrickelectric patrickelectric marked this pull request as draft March 30, 2023 16:33
@CLAassistant
Copy link

CLAassistant commented Aug 23, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fastapi docs don't work offline
3 participants