Add support to more (all?) ardupilot serial boards #3025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Williangalvani
force-pushed
the
all_boards
branch
2 times, most recently
from
0305c9e to
d54ee21
Compare
Williangalvani
force-pushed
the
all_boards
branch
4 times, most recently
from
dae4a7a to
619e3b4
Compare
| @@ -16,13 +16,355 @@ | |||
| from typedefs import FirmwareFormat, FlightController, Platform, PlatformType | |||
|
|
|||
|
|
|||
| def get_board_id(platform: Platform) -> int: | |||
| def get_board_id(board: Union[FlightController, str]) -> int: | |||
| print(board) | |||
| ardupilot_board_ids = { | ||
| Platform.Pixhawk1: 9, | ||
| Platform.Pixhawk4: 50, | ||
| Platform.Pixhawk6X: 53, | ||
| Platform.Pixhawk6C: 56, | ||
| Platform.CubeOrange: 140, | ||
| "PX4_FMU_V1": 5, |
There was a problem hiding this comment.
We should refactor typedefs.Platform no ? It would be nice to unify both implementation
There was a problem hiding this comment.
We can, yes. I was trying to not touch stuff that currently works.
We could leave this PR for after 1.4 and then I can rework it to unify everything.
Williangalvani
commented
Jan 17, 2025
| print(f"Total platform mappings: {platform_count}") | ||
| return | ||
|
|
||
| # If file is invalid or too old, download and process new data |
There was a problem hiding this comment.
it doesnt look like we are checking the age of the file anywhere
Williangalvani
force-pushed
the
all_boards
branch
from
619e3b4 to
edfc650
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm treating this a side-quest as I progress on my KakuteH7 plane
This should add support to all ardupilot boards
TODO:
generate boards.json on CI