Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Dockerfile: export RUST_BACKTRACE #3138

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

patrickelectric
Copy link
Member

@patrickelectric patrickelectric commented Feb 11, 2025

Allow us if rust runtime fails

Summary by Sourcery

Build:

  • Export RUST_BACKTRACE=1 in the Dockerfile.

Signed-off-by: Patrick José Pereira <[email protected]>
Copy link

sourcery-ai bot commented Feb 11, 2025

Reviewer's Guide by Sourcery

This PR enhances debugging for Rust runtime failures by adding an instruction in the Dockerfile to export the RUST_BACKTRACE variable, ensuring backtrace information is available when Rust errors occur. The change is implemented by appending the export statement to the runtime configuration file within the Dockerfile.

Flow diagram for Dockerfile runtime configuration update

flowchart TD
    A[Start Dockerfile execution] --> B[Append export GIT_DESCRIBE_TAGS to $RCFILE_PATH]
    B --> C[Append export HISTFILE to $RCFILE_PATH]
    C --> D[Append export PATH to $RCFILE_PATH]
    D --> E[Append export RUST_BACKTRACE=1 to $RCFILE_PATH]
    E --> F[Setup shortcuts directory]
    F --> G[Finish container configuration]
Loading

File-Level Changes

Change Details Files
Added environment variable setup for RUST_BACKTRACE.
  • Inserted an echo statement to export RUST_BACKTRACE=1 in the Dockerfile.
  • Adjusted the runtime environment configuration to include engine-level Rust debugging information.
core/Dockerfile

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. We don't review packaging changes - Let us know if you'd like us to change this.

@patrickelectric patrickelectric merged commit f5d4aa1 into bluerobotics:master Feb 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants