-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cable-guy: fix falling back to default settings #3140
cable-guy: fix falling back to default settings #3140
Conversation
Reviewer's Guide by SourceryThis pull request addresses an issue in the cable_guy service where the application was falling back to default settings without including a version identifier. The changes add a version field to the default configuration, ensuring consistency with expected schema. Updated class diagram for cable_guy default configurationclassDiagram
class CableGuyManager {
+__init__(default_configs: List<NetworkInterface>)
}
class Settings {
+load() : bool
+root: dict
}
class DefaultConfiguration {
+version: int
+content: List<NetworkInterface>
}
class NetworkInterface {
+dict() : dict
}
CableGuyManager --> Settings : uses
Settings o-- DefaultConfiguration : holds
DefaultConfiguration --> "0..*" NetworkInterface : content
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Williangalvani - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a unit test to verify that the default configuration is correctly applied when loading settings fails.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Bug Fixes: