assets: Add WebcamView #1262
Open
assets: Add WebcamView #1262
+107
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick José Pereira <[email protected]>
patrickelectric
force-pushed
the
add-webcam
branch
4 times, most recently
from
a2c8b3b to
f3ea0f5
Compare
Signed-off-by: Patrick José Pereira <[email protected]>
patrickelectric
force-pushed
the
add-webcam
branch
from
f3ea0f5 to
f7af0d2
Compare
rafaellehmkuhl
requested changes
Aug 19, 2024
There was a problem hiding this comment.
- It looks like its missing the recording part, which I understand is the main reason for this widget, right?
- Can we also have the webcam audio? It looks to me that the recording of both video+audio is what makes this widget valuable.
- No need for a separate commit for adding the widget image (which is needed).
- There are some import fixes to be run for the CI to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #477