Save videos directly to the filesystem (electron-only) #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaellehmkuhl
force-pushed
the
video-on-filesystem
branch
4 times, most recently
from
23b0794 to
5ecff0a
Compare
rafaellehmkuhl
force-pushed
the
video-on-filesystem
branch
5 times, most recently
from
f31bfea to
53fa3e4
Compare
rafaellehmkuhl
force-pushed
the
video-on-filesystem
branch
4 times, most recently
from
c21cbe7 to
461da63
Compare
rafaellehmkuhl
force-pushed
the
video-on-filesystem
branch
8 times, most recently
from
c22259b to
fa42f76
Compare
When the extension was unknown, the video file was being generated with two dots in the end (e.g.: 'video..webm'). This also created a side-effect of the system not being able to find the correspondent telemetry logs and leaving them behind when clearing the videos.
For that an abstraction layer was created. It coordinates the usage of the IndexedDB for the browser version and the filesystem for the Electron version.
rafaellehmkuhl
force-pushed
the
video-on-filesystem
branch
from
fa42f76 to
ebf9cc9
Compare
rafaellehmkuhl
changed the title
rafaellehmkuhl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of the Electron-based application.
Instead of saving the video chunks, video files and telemetry logs to the IndexedDB, we now save them directly to the filesystem.
The main advantage for the user is that it stops risking losing videos on a browser cache cleanup, which was the main cause of video loss. As a side-effect, the user has also the video files directly on their machine, without the need to download them, keeping everything always organized and in sync.
Kapture.2024-12-11.at.05.21.07.mp4
The implementation is done over the renderer/main IPC system, so we don't leave unnecessary filesystem permissions for the client, making everything safe.
Fix #1292.