Fix unlistening to data-lake variables and changing variable in the Plotter widget #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old implementation was removing all listeners when one opted to unlisten.
Old variable was not being unlistened and history was not being reset.
rafaellehmkuhl
force-pushed
the
fix-plotter-variable-change
branch
from
3061c6b to
b62c4d0
Compare
|
@Williangalvani as discussed internally, the problem was indeed fixed. |
Williangalvani
approved these changes
Dec 16, 2024
|
and now I tested, all good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are also renaming the data-lake variables from ["CockpitActionVariable" to "DataLakeVariable"], for consistency.