Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintegrate profiles management #491

Conversation

rafaellehmkuhl
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl commented Sep 21, 2023

This patch reintegrates profile management into the application.

With it one is able to switch between different profiles, delete, rename and event download them.

With it we are also splitting the default profile into two: one for the ROV and one for the Boat. Their layout is yet in discussion.

The patch also adds the ability to download individual views.

Screen.Recording.2023-09-26.at.17.48.58.mov

To be merged after #490.
Fix #368.

@rafaellehmkuhl rafaellehmkuhl force-pushed the reintegrate-profiles-management branch 2 times, most recently from 5579803 to 83d7f94 Compare September 26, 2023 19:44
@rafaellehmkuhl rafaellehmkuhl marked this pull request as ready for review September 26, 2023 20:46
@rafaellehmkuhl rafaellehmkuhl force-pushed the reintegrate-profiles-management branch from e2a2691 to bc5e659 Compare September 27, 2023 14:03
@rafaellehmkuhl
Copy link
Member Author

@patrickelectric rebased from latest master.

const profileRenameDialogRevealed = ref(false)
const profileRenameDialog = useConfirmDialog(profileRenameDialogRevealed)
profileRenameDialog.onConfirm(() => {
// store.renameProfile(profileBeingRenamed.value, newProfileName.value)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lost comment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@rafaellehmkuhl rafaellehmkuhl force-pushed the reintegrate-profiles-management branch from bc5e659 to 8b9fb23 Compare September 27, 2023 14:08
@rafaellehmkuhl rafaellehmkuhl merged commit e0ff2af into bluerobotics:master Sep 27, 2023
4 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the reintegrate-profiles-management branch September 27, 2023 14:12
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Nov 23, 2023
@ES-Alexander ES-Alexander added docs-complete Change documentation has been completed and removed docs-needed Change needs to be documented labels Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-complete Change documentation has been completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should we have per-vehicle defaults?
3 participants