-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintegrate profiles management #491
Merged
rafaellehmkuhl
merged 19 commits into
bluerobotics:master
from
rafaellehmkuhl:reintegrate-profiles-management
Sep 27, 2023
Merged
Reintegrate profiles management #491
rafaellehmkuhl
merged 19 commits into
bluerobotics:master
from
rafaellehmkuhl:reintegrate-profiles-management
Sep 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaellehmkuhl
force-pushed
the
reintegrate-profiles-management
branch
2 times, most recently
from
September 26, 2023 19:44
5579803
to
83d7f94
Compare
…and use the first
Replicate the mechanism used for current view.
There's more than one default profile, so this method does not make sense anymore.
rafaellehmkuhl
force-pushed
the
reintegrate-profiles-management
branch
from
September 27, 2023 14:03
e2a2691
to
bc5e659
Compare
@patrickelectric rebased from latest master. |
patrickelectric
approved these changes
Sep 27, 2023
src/components/EditMenu.vue
Outdated
const profileRenameDialogRevealed = ref(false) | ||
const profileRenameDialog = useConfirmDialog(profileRenameDialogRevealed) | ||
profileRenameDialog.onConfirm(() => { | ||
// store.renameProfile(profileBeingRenamed.value, newProfileName.value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lost comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
This fixes a strange behavior where trying to configure a widget will open the configuration menu of them all. This only happens on a cold boot.
rafaellehmkuhl
force-pushed
the
reintegrate-profiles-management
branch
from
September 27, 2023 14:08
bc5e659
to
8b9fb23
Compare
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 23, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 23, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 23, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 23, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 23, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 24, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 24, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 24, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 24, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 24, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 24, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 24, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 24, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 24, 2023
ES-Alexander
added a commit
to bluerobotics/ardusub-zola
that referenced
this pull request
Nov 24, 2023
ES-Alexander
added a commit
to bluerobotics/ardusub-zola
that referenced
this pull request
Nov 24, 2023
ES-Alexander
added a commit
to bluerobotics/ardusub-zola
that referenced
this pull request
Nov 24, 2023
ES-Alexander
added
docs-complete
Change documentation has been completed
and removed
docs-needed
Change needs to be documented
labels
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch reintegrates profile management into the application.
With it one is able to switch between different profiles, delete, rename and event download them.
With it we are also splitting the default profile into two: one for the ROV and one for the Boat. Their layout is yet in discussion.
The patch also adds the ability to download individual views.
Screen.Recording.2023-09-26.at.17.48.58.mov
To be merged after #490.
Fix #368.