Update joystick pipeline architecture and add modifier/shift buttons support #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rafaellehmkuhl
force-pushed
the
add-mavlink-shift-mapping
branch
2 times, most recently
from
b7bd580 to
d49672d
Compare
rafaellehmkuhl
force-pushed
the
add-mavlink-shift-mapping
branch
from
d49672d to
8068101
Compare
rafaellehmkuhl
force-pushed
the
add-mavlink-shift-mapping
branch
from
8068101 to
d45cc63
Compare
|
I've put various interface suggestions in #617 :-) |
Much more readable.
Being more specific makes it clear that we are talking about `MANUAL_CONTROL` messages on MAVLink, so we don't confuse this with a MAVLink `COMMAND` message, for example, which is used on boats and other vehicles.
rafaellehmkuhl
force-pushed
the
add-mavlink-shift-mapping
branch
4 times, most recently
from
18f052a to
1537800
Compare
…joystick layout component
rafaellehmkuhl
force-pushed
the
add-mavlink-shift-mapping
branch
from
1537800 to
728446e
Compare
rafaellehmkuhl
force-pushed
the
add-mavlink-shift-mapping
branch
2 times, most recently
from
9334f43 to
194ad9b
Compare
rafaellehmkuhl
requested review from
ES-Alexander,
patrickelectric and
Williangalvani
rafaellehmkuhl
force-pushed
the
add-mavlink-shift-mapping
branch
from
194ad9b to
4058404
Compare
…d joystick image This way, if the input is unmapped by the check routines (in the controller store), it will be right in the end.
rafaellehmkuhl
force-pushed
the
add-mavlink-shift-mapping
branch
from
b747093 to
a2267c0
Compare
patrickelectric
approved these changes
Dec 8, 2023
| relay2_momentary = 'Relay 2 momentary', // 105 | ||
| relay3_momentary = 'Relay 3 momentary', // 106 | ||
| relay4_momentary = 'Relay 4 momentary', // 107 | ||
| } |
There was a problem hiding this comment.
| relay2_momentary = 'Relay 2 momentary', // 105 | ||
| relay3_momentary = 'Relay 3 momentary', // 106 | ||
| relay4_momentary = 'Relay 4 momentary', // 107 | ||
| } |
There was a problem hiding this comment.
This is also ArduPilot related, not MAVLink, since Px4 does not provide the same buttons.
There was a problem hiding this comment.
Do you know if there's somewhere we can consume that data from? Or should we have our own database?
12 tasks
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Dec 12, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Dec 12, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Dec 13, 2023
ES-Alexander
added a commit
to bluerobotics/ardusub-zola
that referenced
this pull request
Dec 13, 2023
ES-Alexander
added a commit
to bluerobotics/ardusub-zola
that referenced
this pull request
Dec 13, 2023
ES-Alexander
added a commit
to bluerobotics/ardusub-zola
that referenced
this pull request
Dec 13, 2023
ES-Alexander
added
docs-complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #507
Fix #453