-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Implement a simple exclusive filter by IP address #564
[WIP] Implement a simple exclusive filter by IP address #564
Conversation
@rafaellehmkuhl I have zero knowledge of why Bun is failing, plus, I'm using so much time fighting with the frontend that I feel it would take me hours to make it right, could you assume this from here? |
@@ -244,7 +244,7 @@ watch(externalStreams, () => { | |||
// Retrieve stream from the saved stream name, otherwise choose the first available stream as a fallback | |||
const savedStream = savedStreamName ? availableStreams.value.find((s) => s.name === savedStreamName) : undefined | |||
|
|||
if (savedStream !== undefined && savedStream !== selectedStream.value && selectedStream.value === undefined) { | |||
if (savedStream !== undefined && savedStream.id !== selectedStream.value?.id && selectedStream.value === undefined) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unrelated to the patch, just noticed that was wrong.
@@ -133,7 +182,7 @@ watch(availableStreams, () => { | |||
? availableStreams.value.find((s) => s.name === savedStreamName) | |||
: availableStreams.value.first() | |||
|
|||
if (savedStream !== undefined && savedStream !== selectedStream.value) { | |||
if (savedStream !== undefined && savedStream.id !== selectedStream.value?.id) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unrelated to the patch, just noticed that was wrong.
I can, yes. |
Great, call me if any help is needed! |
Closing in favor of #571 as requested by @joaoantoniocardoso. |
Helps #526
The UI part is so bad, but this simple filter works.