Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove button-like behavior from VeryGenericIndicator #585

Conversation

rafaellehmkuhl
Copy link
Member

This is a deprecated code from when this mini-widget was configured by clicking in it.

@rafaellehmkuhl rafaellehmkuhl force-pushed the dont-allow-generic-indicator-click branch from dcf9979 to 619fbd4 Compare November 22, 2023 20:22
Copy link
Contributor

@ES-Alexander ES-Alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to discuss about making the actual editing mode stuff more understandable / intuitive, but since editing/configuration is no longer done in normal mode then it does make sense to remove the button-like UI stuff.

@rafaellehmkuhl
Copy link
Member Author

We may want to discuss about making the actual editing mode stuff more understandable / intuitive, but since editing/configuration is no longer done in normal mode then it does make sense to remove the button-like UI stuff.

Totally agree.
I also feel like it is hidden and needs to many clicks right now.

@rafaellehmkuhl rafaellehmkuhl merged commit ff06bd6 into bluerobotics:master Nov 23, 2023
7 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the dont-allow-generic-indicator-click branch November 23, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants