-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve mission name usage experience #590
Merged
patrickelectric
merged 5 commits into
bluerobotics:master
from
rafaellehmkuhl:allow-setting-mission-name
Nov 27, 2023
Merged
Improve mission name usage experience #590
patrickelectric
merged 5 commits into
bluerobotics:master
from
rafaellehmkuhl:allow-setting-mission-name
Nov 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the alerter goes right when the mission name grows.
rafaellehmkuhl
changed the title
Allow setting mission name
Improve mission name usage experience
Nov 24, 2023
This will force the user to set new mission names.
This will remember users to set the correct mission name.
rafaellehmkuhl
force-pushed
the
allow-setting-mission-name
branch
from
November 24, 2023 19:44
249773e
to
6bab7c0
Compare
patrickelectric
approved these changes
Nov 27, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Dec 12, 2023
12 tasks
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Dec 12, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Dec 12, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Dec 13, 2023
ES-Alexander
added a commit
to bluerobotics/ardusub-zola
that referenced
this pull request
Dec 13, 2023
ES-Alexander
added a commit
to bluerobotics/ardusub-zola
that referenced
this pull request
Dec 13, 2023
ES-Alexander
added a commit
to bluerobotics/ardusub-zola
that referenced
this pull request
Dec 13, 2023
ES-Alexander
added
docs-complete
Change documentation has been completed
and removed
docs-needed
Change needs to be documented
labels
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch aims to make it easier and more clear to the user that the mission name can be set.
Fix #586