Add alias field, codegen with deprecation comment

bluesky-social · Dec 19, 2024 · 49c45c8 · 49c45c8
1 parent feebf80
commit 49c45c8
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 31 deletions.
diff --git a/packages/api/definitions/labels.json b/packages/api/definitions/labels.json
@@ -147,27 +147,7 @@
   },
   {
     "identifier": "graphic-media",
-    "flags": ["adult"],
-    "configurable": true,
-    "defaultSetting": "warn",
-    "severity": "none",
-    "blurs": "media",
-    "behaviors": {
-      "account": {
-        "avatar": "blur",
-        "banner": "blur"
-      },
-      "profile": {
-        "avatar": "blur",
-        "banner": "blur"
-      },
-      "content": {
-        "contentMedia": "blur"
-      }
-    }
-  },
-  {
-    "identifier": "gore",
+    "alias": ["gore"],
     "flags": ["adult"],
     "configurable": true,
     "defaultSetting": "warn",

diff --git a/packages/api/scripts/code/labels.mjs b/packages/api/scripts/code/labels.mjs
@@ -19,12 +19,42 @@ writeFileSync(
 )
 
 async function gen() {
+  const knownValues = new Set()
+  const flattenedLabelDefs = []
+
+  for (const {alias: aliases, ...label} of labelsDef) {
+    knownValues.add(label.identifier)
+    flattenedLabelDefs.push([label.identifier, { ...label, locales: [] }])
+
+    if (aliases) {
+      for (const alias of aliases) {
+        knownValues.add(alias)
+        flattenedLabelDefs.push([
+          alias,
+          {
+            ...label,
+            identifier: alias,
+            locales: [],
+            comment: `@deprecated alias for \`${label.identifier}\``,
+          },
+        ])
+      }
+    }
+  }
+
+  let labelDefsStr = `{`
+  for (const [key, { comment, ...value }] of flattenedLabelDefs) {
+    const commentStr = comment ? `\n/** ${comment} */\n` : ''
+    labelDefsStr += `${commentStr}'${key}': ${JSON.stringify(value, null, 2)},`
+  }
+  labelDefsStr += `}`
+
   return prettier.format(
     `/** this doc is generated by ./scripts/code/labels.mjs **/
   import {InterpretedLabelValueDefinition, LabelPreference} from '../types'
 
-  export type KnownLabelValue = ${labelsDef
-    .map((label) => `"${label.identifier}"`)
+  export type KnownLabelValue = ${Array.from(knownValues)
+    .map((value) => `"${value}"`)
     .join(' | ')}
 
   export const DEFAULT_LABEL_SETTINGS: Record<string, LabelPreference> = ${JSON.stringify(
@@ -35,13 +65,7 @@ async function gen() {
     ),
   )}
 
-  export const LABELS: Record<KnownLabelValue, InterpretedLabelValueDefinition> = ${JSON.stringify(
-    Object.fromEntries(
-      labelsDef.map((label) => [label.identifier, { ...label, locales: [] }]),
-    ),
-    null,
-    2,
-  )}
+  export const LABELS: Record<KnownLabelValue, InterpretedLabelValueDefinition> = ${labelDefsStr}
   `,
     { semi: false, parser: 'typescript', singleQuote: true },
   )

diff --git a/packages/api/src/moderation/const/labels.ts b/packages/api/src/moderation/const/labels.ts
@@ -16,7 +16,6 @@ export const DEFAULT_LABEL_SETTINGS: Record<string, LabelPreference> = {
   sexual: 'warn',
   nudity: 'ignore',
   'graphic-media': 'warn',
-  gore: 'warn',
 }
 
 export const LABELS: Record<KnownLabelValue, InterpretedLabelValueDefinition> =
@@ -195,6 +194,7 @@ export const LABELS: Record<KnownLabelValue, InterpretedLabelValueDefinition> =
       },
       locales: [],
     },
+    /** @deprecated alias for `graphic-media` */
     gore: {
       identifier: 'gore',
       flags: ['adult'],