Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Thanks Emily!

Co-authored-by: Emily Liu <[email protected]>
  • Loading branch information
bnewbold and emilyliu7321 committed Feb 6, 2024
1 parent 81eb48b commit 563cdd8
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions lexicons/app/bsky/embed/images.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"alt": {
"type": "string",
"description": "Alt-text description of the image, for accessibility."
"description": "Alt text description of the image, for accessibility."
},
"aspectRatio": { "type": "ref", "ref": "#aspectRatio" }
}
Expand Down Expand Up @@ -56,15 +56,15 @@
"properties": {
"thumb": {
"type": "string",
"description": "Fully-qualified URL where a thumbnail of the image can be fetched. For example, CDN location provided by the AppView."
"description": "Fully-qualified URL where a thumbnail of the image can be fetched. For example, CDN location provided by the App View."
},
"fullsize": {
"type": "string",
"description": "Fully-qualified URL where a large version of the image can be fetched. May or may not be the exact original blob. For example, CDN location provided by the AppView."
"description": "Fully-qualified URL where a large version of the image can be fetched. May or may not be the exact original blob. For example, CDN location provided by the App View."
},
"alt": {
"type": "string",
"description": "Alt-text description of the image, for accessibility."
"description": "Alt text description of the image, for accessibility."
},
"aspectRatio": { "type": "ref", "ref": "#aspectRatio" }
}
Expand Down
2 changes: 1 addition & 1 deletion lexicons/app/bsky/embed/recordWithMedia.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"lexicon": 1,
"id": "app.bsky.embed.recordWithMedia",
"description": "A representation of a record embedded in a Bluesky record (eg, a post), alongside other compatible embeds. For example, a quote-post and image, or a quote-post and external URL card.",
"description": "A representation of a record embedded in a Bluesky record (eg, a post), alongside other compatible embeds. For example, a quote post and image, or a quote post and external URL card.",
"defs": {
"main": {
"type": "object",
Expand Down
2 changes: 1 addition & 1 deletion lexicons/app/bsky/feed/describeFeedGenerator.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"defs": {
"main": {
"type": "query",
"description": "Get information about a feed generator, including policies and offered feed URIs. Does not require auth; implemented by Feed Generator services (not AppView).",
"description": "Get information about a feed generator, including policies and offered feed URIs. Does not require auth; implemented by Feed Generator services (not App View).",
"output": {
"encoding": "application/json",
"schema": {
Expand Down
2 changes: 1 addition & 1 deletion lexicons/app/bsky/feed/getFeed.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"defs": {
"main": {
"type": "query",
"description": "Get a hydrated feed from an actor's selected feed generator. Implemented by AppView.",
"description": "Get a hydrated feed from an actor's selected feed generator. Implemented by App View.",
"parameters": {
"type": "params",
"required": ["feed"],
Expand Down
2 changes: 1 addition & 1 deletion lexicons/app/bsky/feed/getListFeed.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"defs": {
"main": {
"type": "query",
"description": "Get a feed of recent posts from a list (aka, posts and reposts from any actors on the list). Does not require auth.",
"description": "Get a feed of recent posts from a list (posts and reposts from any actors on the list). Does not require auth.",
"parameters": {
"type": "params",
"required": ["list"],
Expand Down

0 comments on commit 563cdd8

Please sign in to comment.