Strip trailing colons from link detection, add test (#1944)

bluesky-social · Dec 8, 2023 · 60deea1 · 60deea1
1 parent 842e183
commit 60deea1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/.changeset/grumpy-vans-carry.md b/.changeset/grumpy-vans-carry.md
@@ -0,0 +1,5 @@
+---
+'@atproto/api': patch
+---
+
+Strip trailing colon from URLs in rich-text facet detection.
diff --git a/packages/api/src/rich-text/detection.ts b/packages/api/src/rich-text/detection.ts
@@ -47,7 +47,7 @@ export function detectFacets(text: UnicodeString): Facet[] | undefined {
       const start = text.utf16.indexOf(match[2], match.index)
       const index = { start, end: start + match[2].length }
       // strip ending puncuation
-      if (/[.,;!?]$/.test(uri)) {
+      if (/[.,;:!?]$/.test(uri)) {
         uri = uri.slice(0, -1)
         index.end--
       }

diff --git a/packages/api/tests/rich-text-detection.test.ts b/packages/api/tests/rich-text-detection.test.ts
@@ -41,6 +41,7 @@ describe('detectFacets', () => {
     'start middle end.com/foo/bar?baz=bux#hash',
     'newline1.com\nnewline2.com',
     'a example.com/index.php php link',
+    'a trailing bsky.app: colon',
 
     'not.. a..url ..here',
     'e.g.',
@@ -162,6 +163,7 @@ describe('detectFacets', () => {
       ['example.com/index.php', 'https://example.com/index.php'],
       [' php link'],
     ],
+    [['a trailing '], ['bsky.app', 'https://bsky.app'], [': colon']],
 
     [['not.. a..url ..here']],
     [['e.g.']],