tidy + pr feedback

bluesky-social · Sep 28, 2023 · b2864ca · b2864ca
1 parent 1c30e8c
commit b2864ca
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 831 deletions.
diff --git a/packages/dev-env/src/network-no-appview.ts b/packages/dev-env/src/network-no-appview.ts
@@ -22,7 +22,6 @@ export class TestNetworkNoAppView {
     const pds = await TestPds.create({
       dbPostgresUrl,
       dbPostgresSchema,
-      dbPostgresPoolSize: 5,
       dbSqliteLocation,
       didPlcUrl: plc.url,
       ...params.pds,

diff --git a/packages/pds/src/config/config.ts b/packages/pds/src/config/config.ts
@@ -84,7 +84,7 @@ export const envToCfg = (env: ServerEnvironment): ServerConfig => {
   }
 
   const identityCfg: ServerConfig['identity'] = {
-    plcUrl: env.didPlcUrl ?? 'https://plc.bsky-sandbox.dev',
+    plcUrl: env.didPlcUrl ?? 'https://plc.directory',
     cacheMaxTTL: env.didCacheMaxTTL ?? DAY,
     cacheStaleTTL: env.didCacheStaleTTL ?? HOUR,
     resolverTimeout: env.resolverTimeout ?? 3 * SECOND,
@@ -142,9 +142,14 @@ export const envToCfg = (env: ServerEnvironment): ServerConfig => {
     sequencerLeaderLockId: env.sequencerLeaderLockId ?? 1100,
   }
 
+  if (!env.bskyAppViewUrl) {
+    throw new Error('Must configure PDS_BSKY_APP_VIEW_URL')
+  } else if (!env.bskyAppViewDid) {
+    throw new Error('Must configure PDS_BSKY_APP_VIEW_DID')
+  }
   const bskyAppViewCfg: ServerConfig['bskyAppView'] = {
-    url: env.bskyAppViewUrl ?? 'https://api.bsky-sandbox.dev',
-    did: env.bskyAppViewDid ?? 'did:plc:abc', // get real did
+    url: env.bskyAppViewUrl,
+    did: env.bskyAppViewDid,
     proxyModeration: env.bskyAppViewModeration ?? false,
     cdnUrlPattern: env.bskyAppViewCdnUrlPattern,
   }

diff --git a/packages/pds/src/storage/disk-blobstore.ts b/packages/pds/src/storage/disk-blobstore.ts
@@ -24,7 +24,6 @@ export class DiskBlobStore implements BlobStore {
     this.quarantineLocation = quarantineLocation
   }
 
-  // @TODO move quarantine out of temp by default
   static async create(
     location: string,
     tmpLocation?: string,