PDS - Invalid handles #1246
Open
PDS - Invalid handles #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
reviewed
Jul 24, 2023
packages/pds/src/db/migrations/20230724T194042238Z-optional-handle.ts
Outdated
Show resolved
Hide resolved
devinivy
reviewed
Jul 24, 2023
| expect(bobRes.data.handle).toEqual(HANDLE) | ||
| }) | ||
|
|
||
| it('no longer allows a user to login with a handle they lost due to contention', async () => { |
There was a problem hiding this comment.
As I recall we want to send the user an email in this case. I realize that's not intended to land in this PR, but just wanted to resurface that in case it's blocking.
devinivy
approved these changes
Jul 24, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #1244
handleondid_handlenullable